remove o(n^2) path

socrata · Jan 28, 2020 · 4e3590b · 4e3590b
1 parent 4e18fe1
commit 4e3590b
Showing 1 changed file with 8 additions and 4 deletions.
diff --git a/socrata/sources.py b/socrata/sources.py
@@ -102,14 +102,18 @@ def read(self, how_much):
         if self.done:
             return None
 
-        buf = b''
-        while len(buf) < how_much:
+        buf = []
+        consumed = 0
+        while consumed < how_much:
             try:
-                buf = buf + next(self.gen)
+                chunk = next(self.gen)
+                consumed += len(chunk)
+                buf.append(chunk)
             except StopIteration:
                 self.done = True
                 break
-        return buf
+
+        return b''.join(buf)
 
 
 class Source(Resource, ParseOptionBuilder):