Delete kahu snapshots and CSI snapshots while deleting the volume backup #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -271,6 +318,14 @@ func (ctrl *controller) handleCSISnapshot(snapshot *kahuapi.VolumeSnapshot) erro | |||
| return err | |||
| } | |||
|
|
|||
| func (ctrl *controller) deleteCSISnapshot(snapshot *kahuapi.VolumeSnapshot) error { | |||
| err := ctrl.csiSnapshotHandler.Run(snapshot.Name, func() error { | |||
| ctrl.logger.Infof("Volume Snapshot %s came till before delete func *****", snapshot.Name) | |||
controllers/snapshot/csi/handler.go
Outdated
| @@ -76,8 +78,33 @@ func NewSnapshotter(ctx context.Context, | |||
| }, nil | |||
| } | |||
|
|
|||
| func (s *snapshoter) Delete(snapshot *kahuapi.VolumeSnapshot) error { | |||
| //delete snapshot for each volumes | |||
| // create CSI object | |||
There was a problem hiding this comment.
comment is not proper
controllers/snapshot/csi/handler.go
Outdated
| func (s *snapshoter) Handle(snapshot *kahuapi.VolumeSnapshot) error { | ||
| // create snapshot for each snapshot volumes | ||
| s.logger.Infof(" applying volume snapshot in handle ") |
controllers/snapshot/controller.go
Outdated
| @@ -181,23 +210,41 @@ func (ctrl *controller) processQueue(key string) error { | |||
| return nil | |||
| } | |||
|
|
|||
| if newSnapshot.DeletionTimestamp != nil { | |||
| err := ctrl.deleteCSISnapshot(snapshot) | |||
There was a problem hiding this comment.
move to a delete function
There was a problem hiding this comment.
have updated with a new func
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
kind bug fix
What this PR does / why we need it:
When a backup of pod with volumes is created ,kahu snapshots and CSI snapshots are created
When the backup is deleted the snapshots that were created are not getting removed
This PR makes sures that all the snapshots created while backup are deleted
Which issue(s) this PR fixes:
Fixes #147
Test Report Added?:
Test Report:
Special notes for your reviewer: