Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileShare-DashBoard: FileShare-Access List Order is not proper #925

Closed
satya-gorli opened this issue Jun 25, 2019 · 8 comments · Fixed by sodafoundation/dashboard#179
Closed
Assignees

Comments

@satya-gorli
Copy link
Contributor

Is this a BUG REPORT or FEATURE REQUEST?:

Uncomment only one, leave it on its own line:

/kind bug

What happened:

  1. Create File Share
  2. Create Access..
  3. Repeat Step 2 with different names..
  4. Check the order of the Access Items displayed..
    Not in Created date/Time order.. not by type, not by IP
    What you expected to happen:
    List should display in specific order either sorted by IP or by Creation Date
    How to reproduce it (as minimally and precisely as possible):

FileShareDashBoard_ Incorrect Order of Items

Anything else we need to know?:

Environment:

  • Hotpot(release/branch) version:
  • OS (e.g. from /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Others:
@Shruthi-1MN
Copy link
Contributor

@satya-gorli , This is extra filter option. It is not in scope to do now. Adding more filter can be done as a separate feature enhancement. It should be done all over the project.

@satya-gorli
Copy link
Contributor Author

Its not about new Feature.. Current Listing feature can be in a specific order

@Shruthi-1MN
Copy link
Contributor

@satya-gorli , It is by Acl Id in ascending order, to display in user requested order will be new feature.
Please find results which is proof to the order

  1. From CLI
root@shruthi-VirtualBox:~/go/src/github.com/opensds/opensds# osdsctl fileshare acl list
WARNING: OPENSDS_ENDPOINT is not specified, use default(http://localhost:50040)
WARNING: Not found Env OPENSDS_AUTH_STRATEGY, use default(noauth)
+--------------------------------------+--------------------------------------+------+------------------+--------------+-----------------+
| Id                                   | FileShareId                          | Type | AccessCapability | AccessTo     | Description     |
+--------------------------------------+--------------------------------------+------+------------------+--------------+-----------------+
| 03267a97-1922-443f-add1-56e179ffb99b | 6ad25d59-a160-45b2-8920-211be282e2df | ip   | [Read Write]     | 10.32.104.2  | file share test |
| 12fd4c5a-df51-4446-aa12-ca1a5b8f39ec | 6ad25d59-a160-45b2-8920-211be282e2df | ip   | [Read Write]     | 10.32.104.2  | file share test |
| 1ba29d07-89d5-4fac-bd54-6b243a080eea | 6ad25d59-a160-45b2-8920-211be282e2df | ip   | [Read Write]     | 10.32.104.6  | file share test |
| 31f0ea53-2523-43d0-9e0c-0203c1372738 | 6ad25d59-a160-45b2-8920-211be282e2df | ip   | [Read Write]     | 10.32.104.9  | file share test |
| 37c8767c-dfc3-47ae-859c-86101ea36a9f | 6ad25d59-a160-45b2-8920-211be282e2df | ip   | [Read Write]     | 10.32.104.3  | file share test |
| 3a8f1d77-9d19-4a47-93c7-ea98ba71dcc7 | 6ad25d59-a160-45b2-8920-211be282e2df | ip   | [Read Write]     | 10.32.104.3  | file share test |
| 3e3f5cc2-75ae-42e1-8878-58f84e2da724 | 6ad25d59-a160-45b2-8920-211be282e2df | ip   | [Read Write]     | 10.32.104.11 | file share test |
| 4e3ba7ef-ac24-4998-b9cf-660669755b67 | 6ad25d59-a160-45b2-8920-211be282e2df | ip   | [Read Write]     | 10.32.104.2  | file share test |
| 51eb32f5-4f6a-42c6-b094-b3047c0ea16d | 6ad25d59-a160-45b2-8920-211be282e2df | ip   | [Read Write]     | 10.32.104.2  | file share test |
| 60e810da-b063-48a7-a999-80123b331060 | 6ad25d59-a160-45b2-8920-211be282e2df | ip   | [Read Write]     | 10.32.104.8  | file share test |
| 62868c0c-0ca4-4157-97e7-d0bb1031b197 | 6ad25d59-a160-45b2-8920-211be282e2df | ip   | [Read Write]     | 10.32.104.2  | file share test |
| 68d02a49-8715-4744-914f-a34808cb261c | 6ad25d59-a160-45b2-8920-211be282e2df | ip   | [Read Write]     | 10.32.104.2  | file share test |
| 7cd5f81a-a07c-472e-a9a9-97a5e6ce118e | 6ad25d59-a160-45b2-8920-211be282e2df | ip   | [Read Write]     | 10.32.104.6  | file share test |
| 825e6217-dca3-4426-ba03-3cdc41cee466 | 6ad25d59-a160-45b2-8920-211be282e2df | ip   | [Read Write]     | 10.32.104.7  | file share test |
| 898165cc-b11d-4975-a611-3fd71c596d21 | 6ad25d59-a160-45b2-8920-211be282e2df | ip   | [Read Write]     | 10.32.104.5  | file share test |
| 8a382982-fcfc-48da-b634-474ce906c1c0 | 6ad25d59-a160-45b2-8920-211be282e2df | ip   | [Read Write]     | 10.32.104.13 | file share test |
| 917779ba-cde9-441a-974c-52b557e1c9bc | 6ad25d59-a160-45b2-8920-211be282e2df | ip   | [Read Write]     | 10.32.104.5  | file share test |
| 9f4149be-22c9-4425-91b4-f35901490397 | 6ad25d59-a160-45b2-8920-211be282e2df | ip   | [Read Write]     | 10.32.104.4  | file share test |
| a641fd61-0b24-4f67-8f69-af4912af97ea | 6ad25d59-a160-45b2-8920-211be282e2df | ip   | [Read Write]     | 10.32.104.2  | file share test |
| a8495a47-e80c-4027-9c04-a2d91979438a | 6ad25d59-a160-45b2-8920-211be282e2df | ip   | [Read Write]     | 10.32.104.7  | file share test |
| aea6d04f-ed32-4cb0-afee-036db59cd81d | 6ad25d59-a160-45b2-8920-211be282e2df | ip   | [Read Write]     | 10.32.104.2  | file share test |
| cf5697a3-42f0-47a7-94a3-fc777a085230 | 6ad25d59-a160-45b2-8920-211be282e2df | ip   | [Read Write]     | 10.32.104.10 | file share test |
| d3f25a10-d92e-4d34-baa6-cb46415b2467 | 6ad25d59-a160-45b2-8920-211be282e2df | ip   | [Read Write]     | 10.32.104.12 | file share test |
| d953a48e-e13e-436e-9b4d-23a2e3248524 | 6ad25d59-a160-45b2-8920-211be282e2df | ip   | [Read Write]     | 10.32.104.14 | file share test |
| ebb20f26-09b7-4d05-8225-5f5891e19d76 | 6ad25d59-a160-45b2-8920-211be282e2df | ip   | [Read Write]     | 10.32.104.2  | file share test |
| eed1b943-8850-48ae-9731-610d1fae943b | 6ad25d59-a160-45b2-8920-211be282e2df | ip   | [Read Write]     | 10.32.104.4  | file share test |
| f62424a7-5d06-4cc0-85d3-6d3ccb741cac | 6ad25d59-a160-45b2-8920-211be282e2df | ip   | [Read Write]     | 10.32.104.8  | file share test |
| fcdd6f7e-49f2-4dc6-b57a-8aa484486e4b | 6ad25d59-a160-45b2-8920-211be282e2df | ip   | [Read Write]     | 10.32.104.9  | file share test |
| ff4e1c87-11a0-4f93-8382-a202df30c853 | 6ad25d59-a160-45b2-8920-211be282e2df | ip   | [Read Write]     | 10.32.104.10 | file share test |
+--------------------------------------+--------------------------------------+------+------------------+--------------+-----------------+

  1. Form Curl command
root@shruthi-VirtualBox:~/go/src/github.com/opensds/opensds# curl -X GET http://127.0.0.1:50040/v1beta/e93b4c0934da416eb9c8d120c5d04d96/file/acls
[{"id":"03267a97-1922-443f-add1-56e179ffb99b","createdAt":"2019-07-04T14:31:41","updatedAt":"2019-07-04T14:31:41","tenantId":"e93b4c0934da416eb9c8d120c5d04d96","fileshareId":"6ad25d59-a160-45b2-8920-211be282e2df","type":"ip","accessCapability":["Read","Write"],"accessTo":"10.32.104.2","description":"file share test"},{"id":"12fd4c5a-df51-4446-aa12-ca1a5b8f39ec","createdAt":"2019-07-04T14:31:32","updatedAt":"2019-07-04T14:31:32","tenantId":"e93b4c0934da416eb9c8d120c5d04d96","fileshareId":"6ad25d59-a160-45b2-8920-211be282e2df","type":"ip","accessCapability":["Read","Write"],"accessTo":"10.32.104.2","description":"file share test"},{"id":"1ba29d07-89d5-4fac-bd54-6b243a080eea","createdAt":"2019-07-04T14:36:28","updatedAt":"2019-07-04T14:36:28","tenantId":"e93b4c0934da416eb9c8d120c5d04d96","fileshareId":"6ad25d59-a160-45b2-8920-211be282e2df","type":"ip","accessCapability":["Read","Write"],"accessTo":"10.32.104.6","description":"file share test"},{"id":"31f0ea53-2523-43d0-9e0c-0203c1372738","createdAt":"2019-07-04T14:39:10","updatedAt":"2019-07-04T14:39:11","tenantId":"e93b4c0934da416eb9c8d120c5d04d96","fileshareId":"6ad25d59-a160-45b2-8920-211be282e2df","type":"ip","accessCapability":["Read","Write"],"accessTo":"10.32.104.9","description":"file share test"},{"id":"37c8767c-dfc3-47ae-859c-86101ea36a9f","createdAt":"2019-07-04T14:36:27","updatedAt":"2019-07-04T14:36:28","tenantId":"e93b4c0934da416eb9c8d120c5d04d96","fileshareId":"6ad25d59-a160-45b2-8920-211be282e2df","type":"ip","accessCapability":["Read","Write"],"accessTo":"10.32.104.3","description":"file share test"},{"id":"3a8f1d77-9d19-4a47-93c7-ea98ba71dcc7","createdAt":"2019-07-04T14:39:09","updatedAt":"2019-07-04T14:39:09","tenantId":"e93b4c0934da416eb9c8d120c5d04d96","fileshareId":"6ad25d59-a160-45b2-8920-211be282e2df","type":"ip","accessCapability":["Read","Write"],"accessTo":"10.32.104.3","description":"file share test"},{"id":"3e3f5cc2-75ae-42e1-8878-58f84e2da724","createdAt":"2019-07-04T14:39:11","updatedAt":"2019-07-04T14:39:11","tenantId":"e93b4c0934da416eb9c8d120c5d04d96","fileshareId":"6ad25d59-a160-45b2-8920-211be282e2df","type":"ip","accessCapability":["Read","Write"],"accessTo":"10.32.104.11","description":"file share test"},{"id":"4e3ba7ef-ac24-4998-b9cf-660669755b67","createdAt":"2019-07-04T14:36:27","updatedAt":"2019-07-04T14:36:27","tenantId":"e93b4c0934da416eb9c8d120c5d04d96","fileshareId":"6ad25d59-a160-45b2-8920-211be282e2df","type":"ip","accessCapability":["Read","Write"],"accessTo":"10.32.104.2","description":"file share test"},{"id":"51eb32f5-4f6a-42c6-b094-b3047c0ea16d","createdAt":"2019-07-04T14:31:44","updatedAt":"2019-07-04T14:31:45","tenantId":"e93b4c0934da416eb9c8d120c5d04d96","fileshareId":"6ad25d59-a160-45b2-8920-211be282e2df","type":"ip","accessCapability":["Read","Write"],"accessTo":"10.32.104.2","description":"file share test"},{"id":"60e810da-b063-48a7-a999-80123b331060","createdAt":"2019-07-04T14:39:10","updatedAt":"2019-07-04T14:39:10","tenantId":"e93b4c0934da416eb9c8d120c5d04d96","fileshareId":"6ad25d59-a160-45b2-8920-211be282e2df","type":"ip","accessCapability":["Read","Write"],"accessTo":"10.32.104.8","description":"file share test"},{"id":"62868c0c-0ca4-4157-97e7-d0bb1031b197","createdAt":"2019-07-04T14:31:36","updatedAt":"2019-07-04T14:31:36","tenantId":"e93b4c0934da416eb9c8d120c5d04d96","fileshareId":"6ad25d59-a160-45b2-8920-211be282e2df","type":"ip","accessCapability":["Read","Write"],"accessTo":"10.32.104.2","description":"file share test"},{"id":"68d02a49-8715-4744-914f-a34808cb261c","createdAt":"2019-07-04T14:31:43","updatedAt":"2019-07-04T14:31:43","tenantId":"e93b4c0934da416eb9c8d120c5d04d96","fileshareId":"6ad25d59-a160-45b2-8920-211be282e2df","type":"ip","accessCapability":["Read","Write"],"accessTo":"10.32.104.2","description":"file share test"},{"id":"7cd5f81a-a07c-472e-a9a9-97a5e6ce118e","createdAt":"2019-07-04T14:39:10","updatedAt":"2019-07-04T14:39:10","tenantId":"e93b4c0934da416eb9c8d120c5d04d96","fileshareId":"6ad25d59-a160-45b2-8920-211be282e2df","type":"ip","accessCapability":["Read","Write"],"accessTo":"10.32.104.6","description":"file share test"},{"id":"825e6217-dca3-4426-ba03-3cdc41cee466","createdAt":"2019-07-04T14:39:10","updatedAt":"2019-07-04T14:39:10","tenantId":"e93b4c0934da416eb9c8d120c5d04d96","fileshareId":"6ad25d59-a160-45b2-8920-211be282e2df","type":"ip","accessCapability":["Read","Write"],"accessTo":"10.32.104.7","description":"file share test"},{"id":"898165cc-b11d-4975-a611-3fd71c596d21","createdAt":"2019-07-04T14:39:10","updatedAt":"2019-07-04T14:39:10","tenantId":"e93b4c0934da416eb9c8d120c5d04d96","fileshareId":"6ad25d59-a160-45b2-8920-211be282e2df","type":"ip","accessCapability":["Read","Write"],"accessTo":"10.32.104.5","description":"file share test"},{"id":"8a382982-fcfc-48da-b634-474ce906c1c0","createdAt":"2019-07-04T14:39:11","updatedAt":"2019-07-04T14:39:12","tenantId":"e93b4c0934da416eb9c8d120c5d04d96","fileshareId":"6ad25d59-a160-45b2-8920-211be282e2df","type":"ip","accessCapability":["Read","Write"],"accessTo":"10.32.104.13","description":"file share test"},{"id":"917779ba-cde9-441a-974c-52b557e1c9bc","createdAt":"2019-07-04T14:36:28","updatedAt":"2019-07-04T14:36:28","tenantId":"e93b4c0934da416eb9c8d120c5d04d96","fileshareId":"6ad25d59-a160-45b2-8920-211be282e2df","type":"ip","accessCapability":["Read","Write"],"accessTo":"10.32.104.5","description":"file share test"},{"id":"9f4149be-22c9-4425-91b4-f35901490397","createdAt":"2019-07-04T14:36:28","updatedAt":"2019-07-04T14:36:28","tenantId":"e93b4c0934da416eb9c8d120c5d04d96","fileshareId":"6ad25d59-a160-45b2-8920-211be282e2df","type":"ip","accessCapability":["Read","Write"],"accessTo":"10.32.104.4","description":"file share test"},{"id":"a641fd61-0b24-4f67-8f69-af4912af97ea","createdAt":"2019-07-04T14:31:40","updatedAt":"2019-07-04T14:31:40","tenantId":"e93b4c0934da416eb9c8d120c5d04d96","fileshareId":"6ad25d59-a160-45b2-8920-211be282e2df","type":"ip","accessCapability":["Read","Write"],"accessTo":"10.32.104.2","description":"file share test"},{"id":"a8495a47-e80c-4027-9c04-a2d91979438a","createdAt":"2019-07-04T14:36:28","updatedAt":"2019-07-04T14:36:28","tenantId":"e93b4c0934da416eb9c8d120c5d04d96","fileshareId":"6ad25d59-a160-45b2-8920-211be282e2df","type":"ip","accessCapability":["Read","Write"],"accessTo":"10.32.104.7","description":"file share test"},{"id":"aea6d04f-ed32-4cb0-afee-036db59cd81d","createdAt":"2019-07-04T14:31:37","updatedAt":"2019-07-04T14:31:37","tenantId":"e93b4c0934da416eb9c8d120c5d04d96","fileshareId":"6ad25d59-a160-45b2-8920-211be282e2df","type":"ip","accessCapability":["Read","Write"],"accessTo":"10.32.104.2","description":"file share test"},{"id":"cf5697a3-42f0-47a7-94a3-fc777a085230","createdAt":"2019-07-04T14:39:11","updatedAt":"2019-07-04T14:39:11","tenantId":"e93b4c0934da416eb9c8d120c5d04d96","fileshareId":"6ad25d59-a160-45b2-8920-211be282e2df","type":"ip","accessCapability":["Read","Write"],"accessTo":"10.32.104.10","description":"file share test"},{"id":"d3f25a10-d92e-4d34-baa6-cb46415b2467","createdAt":"2019-07-04T14:39:11","updatedAt":"2019-07-04T14:39:11","tenantId":"e93b4c0934da416eb9c8d120c5d04d96","fileshareId":"6ad25d59-a160-45b2-8920-211be282e2df","type":"ip","accessCapability":["Read","Write"],"accessTo":"10.32.104.12","description":"file share test"},{"id":"d953a48e-e13e-436e-9b4d-23a2e3248524","createdAt":"2019-07-04T14:39:12","updatedAt":"2019-07-04T14:39:12","tenantId":"e93b4c0934da416eb9c8d120c5d04d96","fileshareId":"6ad25d59-a160-45b2-8920-211be282e2df","type":"ip","accessCapability":["Read","Write"],"accessTo":"10.32.104.14","description":"file share test"},{"id":"ebb20f26-09b7-4d05-8225-5f5891e19d76","createdAt":"2019-07-04T14:39:09","updatedAt":"2019-07-04T14:39:09","tenantId":"e93b4c0934da416eb9c8d120c5d04d96","fileshareId":"6ad25d59-a160-45b2-8920-211be282e2df","type":"ip","accessCapability":["Read","Write"],"accessTo":"10.32.104.2","description":"file share test"},{"id":"eed1b943-8850-48ae-9731-610d1fae943b","createdAt":"2019-07-04T14:39:09","updatedAt":"2019-07-04T14:39:09","tenantId":"e93b4c0934da416eb9c8d120c5d04d96","fileshareId":"6ad25d59-a160-45b2-8920-211be282e2df","type":"ip","accessCapability":["Read","Write"],"accessTo":"10.32.104.4","description":"file share test"},{"id":"f62424a7-5d06-4cc0-85d3-6d3ccb741cac","createdAt":"2019-07-04T14:36:28","updatedAt":"2019-07-04T14:36:29","tenantId":"e93b4c0934da416eb9c8d120c5d04d96","fileshareId":"6ad25d59-a160-45b2-8920-211be282e2df","type":"ip","accessCapability":["Read","Write"],"accessTo":"10.32.104.8","description":"file share test"},{"id":"fcdd6f7e-49f2-4dc6-b57a-8aa484486e4b","createdAt":"2019-07-04T14:36:29","updatedAt":"2019-07-04T14:36:29","tenantId":"e93b4c0934da416eb9c8d120c5d04d96","fileshareId":"6ad25d59-a160-45b2-8920-211be282e2df","type":"ip","accessCapability":["Read","Write"],"accessTo":"10.32.104.9","description":"file share test"},{"id":"ff4e1c87-11a0-4f93-8382-a202df30c853","createdAt":"2019-07-04T14:36:29","updatedAt":"2019-07-04T14:36:29","tenantId":"e93b4c0934da416eb9c8d120c5d04d96","fileshareId":"6ad25d59-a160-45b2-8920-211be282e2df","type":"ip","accessCapability":["Read","Write"],"accessTo":"10.32.104.10","description":"file share test"}]

@jimccfun
Copy link
Contributor

@satya-gorli @Shruthi-1MN can the API support more filter. if it can not be supported now, in dashboard I can make listing in specific order.

@PravinRanjan10
Copy link
Contributor

As per satya comment, if dashboard can list in some order, it would looks good and easy for user. I would recommend if you can list the ACl based on time, it would be good. THanks

@jimccfun
Copy link
Contributor

@PravinRanjan10 Your suggestion is good I will take it, thank you

@satya-gorli
Copy link
Contributor Author

/assign @jimccfun

@rhsakarpos
Copy link
Contributor

This is a standard issue on UI table data ordering...sharing some guidelines below, followed in another project with a production grade UI, please see if applicable

  1. the backend API is totally UI AGNOSTIC. that being said, the backend API must guarantee an order ing (to make it idempotent and deterministic) for any consumer of the API. This order must be published in the API doc.
  2. on the UI, any UI component library, will include a table component. This will include a UI model for the column objects. On the table model, the default sorted by column can be set (for on load behavior).
  3. Beyond 2 above, each column will have the sort icons (up and down symbols), where the user can select , to sort the table by which column ?
    4 Another issue we had run into, was to handle sorting of IPs, dates etc. They should NOT be lexicographically sorted
  4. In case any column has varying units for each row...typically a size column, where some rows are in KB, some are in MB etc, the sorting goes haywire...better to have a single unit for ALL rows in the column
  5. if our current UI library does NOT support a rich table model, let us change it. @anvith KS, please weigh in. thanks.
    Just my $0.02.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants