fixes issue#925 #179
fixes issue#925 #179
Conversation
src/app/business/block/file-share-detail/file-share-detail.component.ts
Outdated
Show resolved
Hide resolved
src/app/business/block/file-share-detail/file-share-detail.component.ts
Outdated
Show resolved
Hide resolved
src/app/business/block/file-share-detail/file-share-detail.component.ts
Outdated
Show resolved
Hide resolved
|
LGTM |
|
@wisererik Please review. |
| item.description = "--"; | ||
| } | ||
| item.date = new Date(Utils.formatDate(item.createdAt)).getTime(); | ||
| item.description = (!item.description || item.description == '') ? '--' : item.description; |
There was a problem hiding this comment.
please consider making a reusable util method out of this
There was a problem hiding this comment.
@rhsakarpos I have added this to the backlog ( #186 ) since this is something that will have to be implemented at the application level. If this is agreeable please consider resolving this comment.
| } | ||
| this.acls.push(acl); | ||
| } | ||
| }) | ||
| this.acls.sort((previous,later)=>{ |
There was a problem hiding this comment.
ideally, this is not needed, the table component in the UI should handle this.
There was a problem hiding this comment.
Since the table component is not used and the table is being generated with plain HTML and JS the sort method will have to be used. This can be looked into when we are redesigning the application.
|
@rhsakarpos If the comments are not blockers consider LGTM. I will be taking over the development from here on on this and will consider your suggestions. |
LG...AB |
Fixes sodafoundation/api#925