Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #225. Fix Display host details. #226

Merged
merged 2 commits into from
Dec 4, 2019

Conversation

anvithks
Copy link
Member

@anvithks anvithks commented Dec 4, 2019

The host details were not visible as the API call was not being made. The local object is now removed and the API call is fetching the details.
fixes-225-host-details

Added Initiators and fixed alignments.
fixes-225-host-details-with-initiator

@anvithks anvithks added bug Something isn't working DAITO labels Dec 4, 2019
@anvithks anvithks added this to the Daito SODA v1.0 milestone Dec 4, 2019
@anvithks anvithks self-assigned this Dec 4, 2019
@wisererik
Copy link
Collaborator

where are the initiators

@anvithks
Copy link
Member Author

anvithks commented Dec 4, 2019

where are the initiators

Will push another commit. missed that.

@anvithks
Copy link
Member Author

anvithks commented Dec 4, 2019

@wisererik Please review. Added screenshot above.

Copy link
Collaborator

@wisererik wisererik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@kumarashit kumarashit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kumarashit kumarashit merged commit d3ad5b2 into sodafoundation:development Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working DAITO
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants