Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #229. Added Missing Label in Attach host and other style issues. #230

Merged
merged 1 commit into from
Dec 5, 2019
Merged

Fixes #229. Added Missing Label in Attach host and other style issues. #230

merged 1 commit into from
Dec 5, 2019

Conversation

anvithks
Copy link
Member

@anvithks anvithks commented Dec 4, 2019

  • Fixed the missing label in Attach host page.
    attach-host-label

  • Fixed the placeholder for AZ selection in Create host page.
    create-host-placeholder

@anvithks anvithks added bug Something isn't working DAITO labels Dec 4, 2019
@anvithks anvithks added this to the Daito SODA v1.0 milestone Dec 4, 2019
@anvithks anvithks self-assigned this Dec 4, 2019
kumarashit
kumarashit approved these changes Dec 4, 2019
View reviewed changes
Copy link
Collaborator

@kumarashit kumarashit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wisererik wisererik merged commit 808fe5d into sodafoundation:development Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kumarashit kumarashit kumarashit approved these changes

@wisererik wisererik wisererik approved these changes

Assignees

@anvithks anvithks

Labels
bug Something isn't working DAITO
Projects
None yet
Milestone
Daito SODA v1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anvithks @wisererik @kumarashit