Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #236. Fixed the null value sent in description field in Create snapshot/acl #238

Merged
merged 3 commits into from
Dec 12, 2019

Conversation

anvithks
Copy link
Member

@anvithks anvithks commented Dec 9, 2019

The form fields for Create Snapshot, ACL was reset everytime the dialog was displayed. In the reset method the default values are taken and since the form was not initiated the default was null.
Fixed this by explicitly providing parameters to the form reset method.

create-snapshot
create-snapshot-request

@anvithks anvithks added bug Something isn't working DAITO labels Dec 9, 2019
@anvithks anvithks added this to the Daito SODA v1.0 milestone Dec 9, 2019
@anvithks anvithks self-assigned this Dec 9, 2019
Copy link
Collaborator

@wisererik wisererik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@kumarashit kumarashit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kumarashit kumarashit merged commit 863eecd into sodafoundation:development Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working DAITO
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants