Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Delfin UI] Updated the masking views UI. Added support for resource groups #630

Merged

Conversation

anvithks
Copy link
Member

@anvithks anvithks commented Sep 27, 2021

What type of PR is this?
/kind enhancement

What this PR does / why we need it:
This PR adds support for Storage Host Groups, Volume Groups, Port Groups and the associated display of volumes and ports.

Which issue(s) this PR fixes:
Fixes #629

Test Report Added?:
/kind TESTED

Test Report:
List Masking view
masking-view-1
masking-view-7

Storage Host Groups
masking-view-storage-host-group-4

Storage Host Groups - List Storage Hosts
masking-view-storage-host-group-5

Storage Host Groups - List Storage Host Initiators
masking-view-storage-host-group-6

Volume Groups
masking-view-vol-group-2

Port Groups
masking-view-port-group-3

Special notes for your reviewer:

Tested with vineela1999/masking branch.

@anvithks anvithks added the enhancement New feature or request label Sep 27, 2021
@anvithks anvithks self-assigned this Sep 27, 2021
@anvithks anvithks changed the title [WIP][Delfin UI] Updated the masking views UI. Added support for resource groups [Delfin UI] Updated the masking views UI. Added support for resource groups Sep 28, 2021
Copy link
Member

@NajmudheenCT NajmudheenCT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@skdwriting skdwriting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skdwriting skdwriting merged commit 43712b8 into sodafoundation:master Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Delfin UI] Add support for resource groups in masking views
3 participants