DB Framework for Infra Management #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wisererik
requested changes
Apr 13, 2020
| primaryjoin="and_(" | ||
| "Storage.id==" | ||
| "ConnectionParams.storage_id)") | ||
|
|
There was a problem hiding this comment.
please add all the models here
There was a problem hiding this comment.
Added Volumes and pool for now.. relation with storage is defined, more relations and models need to be added.. once the initial framework is up..
wisererik
reviewed
Apr 15, 2020
dolphin/db/sqlalchemy/models.py
Outdated
| metadata = None | ||
|
|
||
|
|
||
| class ConnectionParams(BASE, DolphinBase): |
There was a problem hiding this comment.
suggest RegistryContext to replace ConnectionParams
| storage_id = Column(String(255)) | ||
| description = Column(String(255)) | ||
| status = Column(String(255)) | ||
| total_capacity = Column(Numeric) |
There was a problem hiding this comment.
is Numeric a double type?
wisererik
approved these changes
Apr 17, 2020
joseph-v
pushed a commit
that referenced
this pull request
Jun 27, 2022
amanr032
pushed a commit
to amanr032/delfin
that referenced
this pull request
Dec 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial DB Framework for Infra Management ,
includes a sample model and implemenation of storage_create operation