-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix when there is more than 2000 volumes rest would timeout issue and change volume name as volume id when the volume name is none #448
Merged
ThisIsClark
merged 8 commits into
sodafoundation:v0.8.0-maint
from
jiangyutan:hitachi_1207
Jan 6, 2021
Merged
fix when there is more than 2000 volumes rest would timeout issue and change volume name as volume id when the volume name is none #448
ThisIsClark
merged 8 commits into
sodafoundation:v0.8.0-maint
from
jiangyutan:hitachi_1207
Jan 6, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ll timeout and change test
… change volume name as volume id when the volume name is none
Codecov Report
@@ Coverage Diff @@
## v0.8.0-maint #448 +/- ##
================================================
- Coverage 67.62% 67.53% -0.10%
================================================
Files 97 97
Lines 7005 7050 +45
Branches 811 819 +8
================================================
+ Hits 4737 4761 +24
- Misses 1990 2005 +15
- Partials 278 284 +6
|
NajmudheenCT
approved these changes
Jan 5, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ThisIsClark
approved these changes
Jan 6, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
NajmudheenCT
pushed a commit
to NajmudheenCT/dolphin-1
that referenced
this pull request
Mar 15, 2021
… change volume name as volume id when the volume name is none (sodafoundation#448) * fix when there is more than 2000 volumes rest would timeout issue and change volume name as volume id when the volume name is none Co-authored-by: Ashit Kumar <akopensrc@gmail.com>
amanr032
pushed a commit
to amanr032/delfin
that referenced
this pull request
Dec 5, 2022
…sabela Release tag update for Isabela
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
1.fix when there is more than 2000 volumes rest would timeout issue;
2. change volume name as volume id when the volume name is non.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Release note: