Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix when there is more than 2000 volumes rest would timeout issue and change volume name as volume id when the volume name is none #448

Merged
merged 8 commits into from
Jan 6, 2021

Conversation

jiangyutan
Copy link
Contributor

What this PR does / why we need it:
1.fix when there is more than 2000 volumes rest would timeout issue;
2. change volume name as volume id when the volume name is non.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

@codecov
Copy link

codecov bot commented Jan 5, 2021

Codecov Report

Merging #448 (48184ae) into v0.8.0-maint (34bdef6) will decrease coverage by 0.09%.
The diff coverage is 78.26%.

@@               Coverage Diff                @@
##           v0.8.0-maint     #448      +/-   ##
================================================
- Coverage         67.62%   67.53%   -0.10%     
================================================
  Files                97       97              
  Lines              7005     7050      +45     
  Branches            811      819       +8     
================================================
+ Hits               4737     4761      +24     
- Misses             1990     2005      +15     
- Partials            278      284       +6     
Impacted Files Coverage Δ
delfin/drivers/hitachi/vsp/rest_handler.py 52.56% <63.15%> (-3.41%) ⬇️
delfin/drivers/hitachi/vsp/vsp_stor.py 75.40% <96.55%> (-0.21%) ⬇️
delfin/drivers/hitachi/vsp/consts.py 100.00% <100.00%> (ø)

Copy link
Member

@NajmudheenCT NajmudheenCT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@ThisIsClark ThisIsClark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ThisIsClark ThisIsClark merged commit 3ac30de into sodafoundation:v0.8.0-maint Jan 6, 2021
NajmudheenCT pushed a commit to NajmudheenCT/dolphin-1 that referenced this pull request Mar 15, 2021
… change volume name as volume id when the volume name is none (sodafoundation#448)

* fix when there is more than 2000 volumes rest would timeout issue and change volume name as volume id when the volume name is none

Co-authored-by: Ashit Kumar <akopensrc@gmail.com>
amanr032 pushed a commit to amanr032/delfin that referenced this pull request Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants