Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add alert_fix fouction and change alerts filter #449

Merged
merged 8 commits into from
Jan 6, 2021
Merged

add alert_fix fouction and change alerts filter #449

merged 8 commits into from
Jan 6, 2021

Conversation

jiangyutan
Copy link
Contributor

What this PR does / why we need it:
1.add alert_fix fouction;
2.change alerts filter

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

@codecov
Copy link

codecov bot commented Jan 5, 2021

Codecov Report

Merging #449 (61f1ad7) into v0.8.0-maint (3ac30de) will decrease coverage by 0.05%.
The diff coverage is 76.92%.

@@               Coverage Diff                @@
##           v0.8.0-maint     #449      +/-   ##
================================================
- Coverage         67.53%   67.47%   -0.06%     
================================================
  Files                97       97              
  Lines              7050     7057       +7     
  Branches            819      822       +3     
================================================
+ Hits               4761     4762       +1     
- Misses             2005     2014       +9     
+ Partials            284      281       -3     
Impacted Files Coverage Δ
delfin/drivers/ibm/storwize_svc/ssh_handler.py 72.69% <75.00%> (-0.83%) ⬇️
delfin/drivers/ibm/storwize_svc/storwize_svc.py 92.59% <100.00%> (-7.41%) ⬇️

Copy link
Member

@NajmudheenCT NajmudheenCT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@ThisIsClark ThisIsClark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ThisIsClark ThisIsClark merged commit dfc0e2a into sodafoundation:v0.8.0-maint Jan 6, 2021
NajmudheenCT pushed a commit to NajmudheenCT/dolphin-1 that referenced this pull request Mar 15, 2021
* add alert_clear test

Co-authored-by: Ashit Kumar <akopensrc@gmail.com>
Co-authored-by: ThisIsClark <liuyuchibubao@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants