Fix for travis CI issue on cryptography dependency #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #494 +/- ##
=======================================
Coverage 67.95% 67.95%
=======================================
Files 113 113
Lines 8217 8217
Branches 926 926
=======================================
Hits 5584 5584
Misses 2321 2321
Partials 312 312 |
NajmudheenCT
changed the title
|
LGTM |
NajmudheenCT
force-pushed
the
travis_test
branch
from
3152b4b to
c4fa7a6
Compare
NajmudheenCT
changed the title
|
LGTM |
wisererik
reviewed
Mar 3, 2021
joseph-v
pushed a commit
to joseph-v/delfin
that referenced
this pull request
Mar 8, 2021
* Fix CI Issue on cryptography dependency * Removing python_version check on crytography package requirement
AmitRoushan
pushed a commit
to AmitRoushan/delfin
that referenced
this pull request
Mar 9, 2021
* Fix CI Issue on cryptography dependency * Removing python_version check on crytography package requirement
AmitRoushan
pushed a commit
to AmitRoushan/delfin
that referenced
this pull request
Mar 9, 2021
* Fix CI Issue on cryptography dependency * Removing python_version check on crytography package requirement
andrewliu83
referenced
this pull request
in gh-ca/delfin
Mar 11, 2021
* Fix CI Issue on cryptography dependency * Removing python_version check on crytography package requirement
AmitRoushan
pushed a commit
to AmitRoushan/delfin
that referenced
this pull request
Mar 12, 2021
* Fix CI Issue on cryptography dependency * Removing python_version check on crytography package requirement
NajmudheenCT
added a commit
that referenced
this pull request
Mar 12, 2021
…e addition (#503) * db changes for task template addition * db changes for task instance addition * Fix for travis CI issue on cryptography dependency (#494) * Fix CI Issue on cryptography dependency * Removing python_version check on crytography package requirement * Add MIXED storage pool type (#482) * Add NAS resources for filesystem, qtree & share (#491) * Add NAS resource filesystem * Separate drivers to NAS, SAN and Unified * Fix formatting * Add Qtree resource support to delfin * Add Share resource support to delfin * Add quota limit params to qtree * Update unit tests * Update model changes * Implement review comments * update db model with task and failed task schema * Fix some comments and name changes * Unit test changes Co-authored-by: Najmudheen <45681499+NajmudheenCT@users.noreply.github.com> Co-authored-by: Joseph Vazhappilly <josephvp@gmail.com> Co-authored-by: Amit Roushan <amit.roushan@huawei.com>
NajmudheenCT
added a commit
to NajmudheenCT/dolphin-1
that referenced
this pull request
Mar 15, 2021
* Fix CI Issue on cryptography dependency * Removing python_version check on crytography package requirement
wisererik
pushed a commit
that referenced
this pull request
Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
A bump in the cryptography indirect dependency lead to cascading breaking changes in our direct dependency pyopenssl. This PR fixes this by directing adding cryptography to our requirements.txt and reverting to a previous cryptography version.
RCA
Newly added cryptography package requires rust compiler .
For more reading about the rust problem in new cryptography version you can read in their github page : pyca/cryptography#5771
Due to this existing travis CI build is failed. reported by some other open source community too
some references
cyberark/cyberark-conjur-cli#183
plotly/dash#1551
In delfin we have cryptography package dependency with pyopenssl . pyopenssl version we use is 19.1 , which supports crypto version 2.8 or above . problematic cryptography version is 3.4.1
Solution
Issue only seems problematic on Python 3.6 . We can attempt use required cryptography version on python 3.6
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #NA
Special notes for your reviewer:
Release note: