Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Filesystem metrics to capability #667

Merged
merged 3 commits into from
Aug 5, 2021

Conversation

NajmudheenCT
Copy link
Member

What this PR does / why we need it:
Adding NAS resources ( filesystem) metrics to delfin capability list.
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #659

Special notes for your reviewer:

Test Report:

image

Release note:

@codecov
Copy link

codecov bot commented Aug 3, 2021

Codecov Report

Merging #667 (7749bfb) into master (ee30ed8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #667   +/-   ##
=======================================
  Coverage   70.07%   70.07%           
=======================================
  Files         156      156           
  Lines       14536    14536           
  Branches     1764     1764           
=======================================
  Hits        10186    10186           
  Misses       3778     3778           
  Partials      572      572           
Impacted Files Coverage Δ
delfin/api/schemas/storage_capabilities_schema.py 100.00% <ø> (ø)
delfin/drivers/fake_storage/__init__.py 90.64% <ø> (ø)

@NajmudheenCT NajmudheenCT changed the title Adding Files ystem metrics to capability Adding Filesystem metrics to capability Aug 4, 2021
Copy link
Collaborator

@ThisIsClark ThisIsClark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@joseph-v joseph-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@wisererik wisererik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NajmudheenCT NajmudheenCT merged commit 62dd6f1 into sodafoundation:master Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add performance metrics for NAS resources
4 participants