Add support for multiple arrays of Embedded Unisphere #697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joseph-v
force-pushed
the
vmax-multi-array-fix
branch
2 times, most recently
from
e7914d2 to
f9f6e82
Compare
Codecov Report
@@ Coverage Diff @@
## master #697 +/- ##
==========================================
- Coverage 70.52% 70.45% -0.08%
==========================================
Files 163 163
Lines 15871 15886 +15
Branches 1972 1976 +4
==========================================
- Hits 11193 11192 -1
- Misses 4020 4033 +13
- Partials 658 661 +3
|
wisererik
reviewed
Sep 16, 2021
delfin/drivers/dell_emc/vmax/rest.py
Outdated
| 'status_code': status_code}) | ||
| LOG.info("No response received from API. Status code " | ||
| "received is: %(status_code)s", | ||
| {'status_code': status_code}) |
There was a problem hiding this comment.
why need info log here?
joseph-v
force-pushed
the
vmax-multi-array-fix
branch
from
f9f6e82 to
5ee4f0d
Compare
|
please fix i issue |
joseph-v
force-pushed
the
vmax-multi-array-fix
branch
2 times, most recently
from
1f5648e to
d1b8ee0
Compare
joseph-v
force-pushed
the
vmax-multi-array-fix
branch
from
d1b8ee0 to
11afb9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add support for multiple arrays of Embedded Unisphere
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Release note: