[WIP] Implement NetAPP Eseries SAN Driver Support #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Click2Cloud-Faizan this is WIP, only because, it is not tested on the device?! |
kumarashit
requested changes
Jul 8, 2020
| defaultConfPath = "/etc/opensds/driver/netapp_eseries_storage.yaml" | ||
| DefaultAZ = "default" | ||
| StorageDriverName = "eseries-san" | ||
| volumePrefix = "opensds_" |
There was a problem hiding this comment.
Can we rename these to soda?
| func (d *SANDriverE) TerminateConnection(opt *pb.DeleteVolumeAttachmentOpts) error { | ||
| var name = getVolumeName(opt.GetVolumeId()) | ||
|
|
||
| // Validate ExtantVolume exists before destroying |
| . "github.com/sodafoundation/dock/contrib/drivers/utils/config" | ||
| ) | ||
|
|
||
| //type BackendOptions struct { |
There was a problem hiding this comment.
You can remove these ONTAP models
| @@ -31,11 +31,12 @@ require ( | |||
| github.com/jonboulle/clockwork v0.1.0 // indirect | |||
| github.com/mitchellh/copystructure v1.0.0 // indirect | |||
| github.com/mitchellh/mapstructure v1.1.2 | |||
| github.com/netapp/trident v19.10.0+incompatible | |||
| github.com/netapp/trident v19.10.1+incompatible | |||
There was a problem hiding this comment.
I hope this change won't have any impact on current ONTAP support
| @@ -0,0 +1,74 @@ | |||
| package eseries | |||
|
|
|||
There was a problem hiding this comment.
Can we have a common model for Netapp SAN? Except few, most of the entities or objects may remain same, example pool, volume or aggregates or LUNs etc,,,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Currently we have lvm, ceph etc. as the backend drivers.
This PR is to address implementing NetApp Eseries Driver Adapter for OpenSDS SBD.
Add NetAPP Storage driver to provide support for NetAPP Eseries storage.
Test Report Added?:
NOT-TESTED
Testing Steps: https://github.com/Click2Cloud/design-specs/blob/master/SBD_Testing_Steps.md
Release notes: