Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the snapshot profile for multicloud snapshot of block devices to S3 #66

Merged
merged 2 commits into from
Dec 30, 2020

Conversation

kumarashit
Copy link
Collaborator

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind new feature
/kind bug fix
/kind cleanup
/kind revert change
/kind design
/kind documentation
/kind enhancement

What this PR does / why we need it:
This will fix the access protocol set for dock for specific profile. Also, makes the multicloud driver S3 compatible.

Which issue(s) this PR fixes:

Fixes #60

Test Report Added?:

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line: /kind TESTED
/kind NOT-TESTED

Test Report:
Tested the code to connect the S3 Endpoint and start multi-part upload to s3. Need to fix the Signature and authentication error for s3 next

Special notes for your reviewer:

@codecov
Copy link

codecov bot commented Dec 22, 2020

Codecov Report

Merging #66 (0c20bcc) into master (b0132ba) will decrease coverage by 0.01%.
The diff coverage is 6.25%.

@@            Coverage Diff             @@
##           master      #66      +/-   ##
==========================================
- Coverage   25.59%   25.57%   -0.02%     
==========================================
  Files          40       40              
  Lines        8006     8011       +5     
==========================================
  Hits         2049     2049              
- Misses       5725     5730       +5     
  Partials      232      232              
Impacted Files Coverage Δ
contrib/backup/multicloud/client.go 0.00% <0.00%> (ø)
contrib/drivers/lvm/lvm.go 23.40% <0.00%> (-0.08%) ⬇️
pkg/dock/discovery/discovery.go 34.70% <ø> (ø)
pkg/dock/dock.go 11.78% <0.00%> (-0.14%) ⬇️
contrib/backup/multicloud/driver.go 5.81% <33.33%> (-0.07%) ⬇️

Copy link
Contributor

@wisererik wisererik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@skdwriting skdwriting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skdwriting skdwriting merged commit b983239 into sodafoundation:master Dec 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Block Snapshot backup to S3
3 participants