Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tutorial] How to develop single page application with Angular #281

Open
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

rishibaghel25
Copy link

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind new feature
/kind bug fix
/kind cleanup
/kind revert change
/kind design
/kind documentation
/kind enhancement

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Test Report Added?:

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind TESTED
/kind NOT-TESTED

Test Report:

Special notes for your reviewer:

Copy link
Member

@anvithks anvithks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @rishibaghel25 @2108vijay @reevdonatusben789 @priyakumari16
A few suggestions and changes requested.

  • You can remove the code for the sample project from here and host it in a repo of its own and provide the link. We just want the readme document on how to setup angular routing.
  • The documentation that you have to write is not for building a simple Angular app. It is for Angular routing. I do not see any information regarding Angular routing and how to use it. Consider adding that to the documentation.
  • The Readme at the root folder learning/dashboard has been deleted. Please add it back.

Edit: My mistake. I mixed up the two PRs for angular app and Angular routing.

@anvithks anvithks changed the title How to develop single page application with Angular [Tutorial] How to develop single page application with Angular Mar 23, 2023
@rishibaghel25
Copy link
Author

changes done

@rishibaghel25 rishibaghel25 requested a review from anvithks March 25, 2023 02:52
Copy link
Member

@anvithks anvithks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants