-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tutorial] How to develop single page application with Angular #281
base: master
Are you sure you want to change the base?
Conversation
Update readme.md
Update readme.md
Update readme.md
Update readme.md
Update readme.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @rishibaghel25 @2108vijay @reevdonatusben789 @priyakumari16
A few suggestions and changes requested.
- You can remove the code for the sample project from here and host it in a repo of its own and provide the link. We just want the readme document on how to setup angular routing.
The documentation that you have to write is not for building a simple Angular app. It is for Angular routing. I do not see any information regarding Angular routing and how to use it. Consider adding that to the documentation.- The Readme at the root folder
learning/dashboard
has been deleted. Please add it back.
Edit: My mistake. I mixed up the two PRs for angular app and Angular routing.
learning/dashboard/How to develop single page application with Angular/readme.md
Outdated
Show resolved
Hide resolved
learning/dashboard/How to develop single page application with Angular/Hello-World/.gitignore
Outdated
Show resolved
Hide resolved
...ning/dashboard/How to develop single page application with Angular/Hello-World/.editorconfig
Outdated
Show resolved
Hide resolved
...ashboard/How to develop single page application with Angular/Hello-World/.vscode/launch.json
Outdated
Show resolved
Hide resolved
changes done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thank you @rishibaghel25 @priyakumari16 @Rishikesh-50 @reevdonatusben789 @2108vijay
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Test Report Added?:
Test Report:
Special notes for your reviewer: