Updated index.md with icons #296
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue sodafoundation#83 Added Icon for Twitter / GitHub / Linked etc. icons on Introduction page.
anvithks
requested changes
Apr 3, 2023
content/introduction/_index.md
Outdated
| - [SODA Twitter](https://twitter.com/sodafoundation) | ||
| - [SODA Mailing List](https://lists.sodafoundation.io) | ||
| - [SODA LinkedIn](https://www.linkedin.com/company/sodafoundation/) | ||
| - <img src="https://github.com/FortAwesome/Font-Awesome/blob/6.x/svgs/brands/github.svg" width="20" height="20"> [SODA Website](https://sodafoundation.io/the-foundation/join/) |
There was a problem hiding this comment.
Please check the deploy preview.
The logos are not appearing.
There was a problem hiding this comment.
sure sir...I will check and update it....Thank you
|
@ArjunGK22 Please check the deploy preview. Looks like the alignment is not correct. Consider a different approach to making this section. You need not just add the logos to the list. |
|
Is there any way to look at the deployment preview before giving a pull request. Becoz when I see locally it is perfect. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #83
Added Icon for Twitter / GitHub / Linked etc. icons on Introduction page.
What type of PR is this?
This PR adds the icons to the links like github, mail, linkedin, slack in the introduction page.
What this PR does / why we need it:
Gives a visual navigation to user rather than just textual.
Which issue(s) this PR fixes:
Fixes #83Test Report Added?:
Test Report:
Special notes for your reviewer:
@anvithks Kindly have a look at it and let me know if any changes has to be made. Thank you