Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix delfin OS version for 18.04 & 16.04 #372

Merged
merged 2 commits into from
Jan 5, 2021

Conversation

joseph-v
Copy link
Collaborator

What type of PR is this?

Fix delfin OS version for supporting both 18.04 & 16.04

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind new feature
/kind bug fix
/kind cleanup
/kind revert change
/kind design
/kind documentation
/kind enhancement

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Test Report Added?:

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind TESTED
/kind NOT-TESTED

Test Report:

Special notes for your reviewer:

@@ -23,34 +23,34 @@

- name: Add RabbitMQ official repo
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to check this for non-ubuntu OS too

@joseph-v joseph-v force-pushed the fix_osversion_delfin branch from 31ce07d to 95fb7dd Compare January 5, 2021 14:16
Copy link
Member

@NajmudheenCT NajmudheenCT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update this branch , this fix is required for smooth installation VMs

@@ -23,34 +23,34 @@

- name: Add RabbitMQ official repo
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Order of this need to be changed, first name: Import RabbitMQ public key and then follwed by name: Add RabbitMQ official repo

@joseph-v joseph-v force-pushed the fix_osversion_delfin branch from 01fc48e to 94ac3ba Compare January 5, 2021 16:50
Copy link
Member

@NajmudheenCT NajmudheenCT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@kumarashit kumarashit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@skdwriting skdwriting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skdwriting skdwriting merged commit 67ab14f into sodafoundation:master Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants