Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 1230-1 : Use secrets in Pod Yamls. #1256

Merged
merged 3 commits into from
Apr 28, 2021

Conversation

rajat-soda
Copy link
Contributor

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind new feature
/kind bug fix
/kind cleanup
/kind revert change
/kind design
/kind documentation
/kind enhancement

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #1230

Test Report Added?:

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
kind TESTED
/kind NOT-TESTED

Test Report:

image

Special notes for your reviewer:

@codecov
Copy link

codecov bot commented Apr 17, 2021

Codecov Report

Merging #1256 (c286ebb) into master (055adb0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1256   +/-   ##
=======================================
  Coverage   48.00%   48.00%           
=======================================
  Files          10       10           
  Lines        1450     1450           
=======================================
  Hits          696      696           
  Misses        702      702           
  Partials       52       52           

Copy link
Collaborator

@kumarashit kumarashit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rajat-soda
Copy link
Contributor Author

@asifdxtreme , @AmitRoushan Please review

Copy link

@AmitRoushan AmitRoushan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, MongoDB INITDB username password should be scerets

K8s/soda-secret.yaml Outdated Show resolved Hide resolved
K8s/soda-secret.yaml Show resolved Hide resolved
Copy link

@AmitRoushan AmitRoushan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me

Copy link
Member

@NajmudheenCT NajmudheenCT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NajmudheenCT NajmudheenCT merged commit 0b1725c into sodafoundation:master Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Future: Misc issues in Kubernetes manifests.
4 participants