-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 1230-1 : Use secrets in Pod Yamls. #1256
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1256 +/- ##
=======================================
Coverage 48.00% 48.00%
=======================================
Files 10 10
Lines 1450 1450
=======================================
Hits 696 696
Misses 702 702
Partials 52 52 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@asifdxtreme , @AmitRoushan Please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO, MongoDB INITDB username password should be scerets
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #1230
Test Report Added?:
Test Report:
Special notes for your reviewer: