Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

framework_test: existing.txt #146

Closed
matthieu-nesme opened this issue Jan 25, 2017 · 2 comments
Closed

framework_test: existing.txt #146

matthieu-nesme opened this issue Jan 25, 2017 · 2 comments
Assignees
@damienmarchal
Milestone
v17.06

Comments

@matthieu-nesme
Copy link
Member

What is the file SofaKernel/framework/framework_test/resources/existing.txt?
Does it really need to be pushed? Could it be removed and added to .gitignore?
It seems to be modified when running the test.
@damienmarchal
Copy link
Contributor

damienmarchal commented Jan 25, 2017 •
edited
Loading

@matthieu-nesme you are right the "existing.txt" file is created to validate the behavior of the FileMonitor API. It should be added to .gitignore as well as probably removed when the test terminates.
Edit: typos

@damienmarchal damienmarchal mentioned this issue May 2, 2017
Merged
7 tasks
@damienmarchal
Copy link
Contributor

Let's close it (even before the merge of the PR)

@guparan guparan modified the milestone: v17.06 Jun 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@damienmarchal damienmarchal

Labels
None yet
Projects
None yet
Milestone
v17.06
Development

No branches or pull requests
3 participants
@guparan @matthieu-nesme @damienmarchal