Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[all] Defrost cleaning week18 #258

Merged
merged 21 commits into from
May 10, 2017
Merged

[all] Defrost cleaning week18 #258

merged 21 commits into from
May 10, 2017

Conversation

damienmarchal
Copy link
Contributor

@damienmarchal damienmarchal commented Apr 28, 2017 •
edited
Loading

This is the Defrost week contribution in cleaning & testing.

CHANGE for Hugo:

  • [FileMonitor] fix the recurrent problem with file 'SofaKernel/framework/framework_test/resources/existing.txt' pointed in Issue framework_test: existing.txt #146
  • [ConstantForceField] clean to follow sofa guideline & fix the "visible dependencies",
  • [ConstantForceField] replace the "points" attribute by "indices" (with backward compatibility & deprecation message)
  • [ConstantForceField] add test in ConstantForceField_test, some of them are OpenIssue demonstrating existing problem (as crashing sofa when using negative (or too large) values in indices).
  • [Light] clean and strenghening the interface
  • [Light] add tests
  • [DefaultAnimationLoop] add tests
  • [LocalMinDistance] add tests
  • [RequiredPlugin] add tests
  • [ClipPlane] add tests
  • [DistanceGrid] add tests

This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings nor unit test failures.
  • does not break existing scenes.
  • does not break API compatibility.
  • has been reviewed and agreed to be transitional.
  • is more than 1 week old (or has fast-merge label).
  • reports important changes in Changelog.

Reviewers will merge only if all these checks are true.

damienmarchal and others added 14 commits March 28, 2017 00:39
@damienmarchal
Merge branch 'cleaning_week11' into Defrost_cleaning_week13
9fea974
@damienmarchal
[SofaVolumetricData] DistanceGrid tests.
efef307
@damienmarchal
[SofaBoundaryCondition] Clean ConstantForceField + add test.
2dfbede 
As ConstantForceField seems to be one of the 20 selected component
for SofaNG I start some cleaning on it.

The cleaning include:
   - renaming data field to follow the sofa guideline
   - adding several simple test to validate the input behavior (to avoid
     crash when users are changing values in their xml files).
@damienmarchal
Merge remote-tracking branch 'upstream/master' into constantforcefeld…
f07ec0e 
…_cleaning

# Conflicts:
#	modules/SofaBoundaryCondition/ConstantForceField.h
#	modules/SofaBoundaryCondition/ConstantForceField.inl
@damienmarchal
[SofaBoundaryCondition] Fix compilation problem because of merge.
1e1a761
@damienmarchal
[Compliant] Fix compilation problem because of renaming in ConstantFo…
059365c 
…rceField.
@bcarrez
[SofaGraphComponent] ADD RequiredPlugin_test
52b0346
@damienmarchal
[Compliant] Fix compilation error.
ecc8189
@damienmarchal
Merge branch 'defrost_cleaning_week18' of github.com:SofaDefrost/sofa…
68d39da 
… into defrost_cleaning_week18
@bcarrez
FIX delete annoying test file "existing.txt"
c1fc92e
@damienmarchal
[SofaBoundary] add a new test to constant force field.
c54b709
@damienmarchal
Merge branch 'defrost_cleaning_week18' of github.com:SofaDefrost/sofa…
ba427c1 
… into defrost_cleaning_week18
@bcarrez
[SofaFramework] ADD DefaultAnimationLoop_test
cc80bb4
@damienmarchal
[SofaOpenggl] Add more tests.
f0dbdb5
@damienmarchal
Copy link
Contributor Author

[ci-build]

@damienmarchal damienmarchal mentioned this pull request May 3, 2017
Closed
@hugtalbot hugtalbot changed the title Defrost cleaning week18 [all] Defrost cleaning week18 May 3, 2017
@damienmarchal damienmarchal added pr: status to review To notify reviewers to review this pull-request pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels May 3, 2017
@hugtalbot hugtalbot merged commit 9cb92ed into sofa-framework:master May 10, 2017
@hugtalbot
Copy link
Contributor

Thank you for the ChangeLog @damienmarchal

@bcarrez bcarrez mentioned this pull request May 12, 2017
Merged
6 tasks
hugtalbot pushed a commit that referenced this pull request May 12, 2017
UPDATE Changelog with #213 and #258
f3dcf68
@guparan guparan added the pr: clean Cleaning the code label Jun 29, 2017
@guparan guparan added this to the v17.06 milestone Jun 29, 2017
@damienmarchal damienmarchal deleted the defrost_cleaning_week18 branch July 5, 2017 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr: clean Cleaning the code pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v17.06
Development

Successfully merging this pull request may close these issues.
4 participants
@damienmarchal @hugtalbot @guparan @bcarrez