Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation error when SOFA_FLOATING_POINT_TYPE = float #2

Closed
FabienPean opened this issue Jun 3, 2016 · 3 comments
Closed

Compilation error when SOFA_FLOATING_POINT_TYPE = float #2

FabienPean opened this issue Jun 3, 2016 · 3 comments
Assignees
Milestone

Comments

@FabienPean
Copy link
Contributor

Details

If the option in the CMake file SOFA_FLOATING_POINT_TYPE is set on float only. Compilation fails initially in SofaDenseSolver library due to errors with the Newmat library, which propagates in further dependencies. It seems that there is no float version of the methods inside Newmat.

Build output sample

  • 3> Creating library C:/.../lib/Debug/SofaDenseSolver_d.lib and object C:/.../lib/Debug/SofaDenseSolver_d.exp
  • 3>LULinearSolver.obj : error LNK2001: unresolved external symbol "public: virtual float __cdecl NEWMAT::BaseMatrix::SumSquare(void)const " (?SumSquare@BaseMatrix@NEWMAT@@UEBAMXZ)
  • 3>NewMatCGLinearSolver.obj : error LNK2001: unresolved external symbol "public: virtual float __cdecl NEWMAT::BaseMatrix::SumSquare(void)const " (?SumSquare@BaseMatrix@NEWMAT@@UEBAMXZ)
  • 3>initDenseSolver.obj : error LNK2001: unresolved external symbol "public: virtual float __cdecl NEWMAT::BaseMatrix::SumSquare(void)const " (?SumSquare@BaseMatrix@NEWMAT@@UEBAMXZ)
  • 3>LULinearSolver.obj : error LNK2001: unresolved external symbol "public: virtual float __cdecl NEWMAT::BaseMatrix::SumAbsoluteValue(void)const " (?SumAbsoluteValue@BaseMatrix@NEWMAT@@UEBAMXZ)
@damienmarchal
Copy link
Contributor

Is this issue still true ? It is not closed and it is waiting since 9 month

@hugtalbot
Copy link
Contributor

@FabienPean any update on this ?
still an issue ?

@FabienPean
Copy link
Contributor Author

Well initially I just reported the error and did not necessarily plan to look for the fix, so yes the the error still holds. It was just to try out the option but it was not a blocking issue as, I think, people uses double option or both.
So in the end, I decided to take a look at that. I think I solved the issue. PR to come.

@guparan guparan added this to the v17.06 milestone Jul 5, 2017
@guparan guparan closed this as completed Jul 5, 2017
guparan referenced this issue in guparan/sofa Jul 12, 2018
bakpaul added a commit to olivier-roussel/sofa that referenced this issue Feb 21, 2024
bakpaul added a commit that referenced this issue Feb 27, 2024
* Link dynamically with embedded metis to comply conda-forge rules

* export all symbols (for MSVC)

* Use external 5.1.0 metis or fallback to embedded code linked dynamically

* fix comments in metis cmake module

* ADD find or fetch mechanism

* Remove embeded metis and put linkage to private

* Fix metis dependency but still not the best fix

* test

* Put back public linkage

* Revert "Put back public linkage"

This reverts commit 71baa47.

* Clean

* cleaning #2

* Use SOFA_ALLOW_FETCH_DEPENDENCIES cmake option for metis

* Add missing CImg to list of fetchable dependencies in doc

* Update applications/plugins/SofaMatrix/CMakeLists.txt

Co-authored-by: Frederick Roy <fredroy@users.noreply.github.com>

---------

Co-authored-by: Frederick Roy <froy@lnrobo.com>
Co-authored-by: Paul Baksic <30337881+bakpaul@users.noreply.github.com>
Co-authored-by: bakpaul <bakpaul@hotmail.fr>
Co-authored-by: Paul Baksic <paul.baksic@outlook.fr>
Co-authored-by: Frederick Roy <fredroy@users.noreply.github.com>
bakpaul added a commit that referenced this issue Feb 27, 2024
* Link dynamically with embedded metis to comply conda-forge rules

* export all symbols (for MSVC)

* Use external 5.1.0 metis or fallback to embedded code linked dynamically

* fix comments in metis cmake module

* ADD find or fetch mechanism

* Remove embeded metis and put linkage to private

* Fix metis dependency but still not the best fix

* test

* Put back public linkage

* Revert "Put back public linkage"

This reverts commit 71baa47.

* Clean

* cleaning #2

* Use SOFA_ALLOW_FETCH_DEPENDENCIES cmake option for metis

* Add missing CImg to list of fetchable dependencies in doc

* Update applications/plugins/SofaMatrix/CMakeLists.txt

Co-authored-by: Frederick Roy <fredroy@users.noreply.github.com>

---------

Co-authored-by: Frederick Roy <froy@lnrobo.com>
Co-authored-by: Paul Baksic <30337881+bakpaul@users.noreply.github.com>
Co-authored-by: bakpaul <bakpaul@hotmail.fr>
Co-authored-by: Paul Baksic <paul.baksic@outlook.fr>
Co-authored-by: Frederick Roy <fredroy@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants