[packages] Move all SofaComponent* + rename SofaAllCommonComponents #1155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Better consistency with the other SofaComponent* packages
\.h\.in is a correct regex but CMake complains about it
guparan
added
pr: status to review
guparan
commented
Sep 26, 2019
| @@ -22,10 +22,10 @@ | |||
| #ifndef SOFA_HELPER_SYSTEM_GL_H | |||
| #define SOFA_HELPER_SYSTEM_GL_H | |||
|
|
|||
| #include <sofa/helper/system/config.h> | |||
There was a problem hiding this comment.
Sorry, this is a fix that has nothing to do with my PR.
Still, it is needed when SOFA_NO_OPENGL is ON.
|
[ci-build][with-all-tests] |
This reverts commit 5b3d1c4.
guparan
added
pr: status wip
…faComponent # Conflicts: # SofaKernel/SofaFramework/SofaMacros.cmake
guparan
added
pr: status to review
guparan
force-pushed
the
refactor_SofaComponent
branch
from
7511da0 to
c65f13e
Compare
hugtalbot
added
pr: status ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an old work that has already been merged into ng branch (see #620) but since the NG task is paused for now I think it would be appreciable to have this in master.
The idea is to remove SofaComponent* from modules (because they are not modules) and put them next to SofaAllCommonComponents.
Concretely, this PR does:
This PR:
Reviewers will merge only if all these checks are true.