Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SofaPhysicsApi] Compilation FIX #167

Merged
merged 17 commits into from
Mar 8, 2017

Conversation

epernod
Copy link
Contributor

@epernod epernod commented Feb 10, 2017

Quick PR to fix the SofaPhysicsApi project

  • Remove deprecated code regarding OpenGL tetrahedron.
  • FIX some bad path in cpack installation
  • Change some class declaration to allow inheritance.

This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings nor unit test failures.
  • does not break existing scenes.
  • does not break API compatibility.
  • has been reviewed
  • is more than 1 week old.
    Reviewers will merge only if all this checks are true.

…d fix its compilation by commenting all use of oglTetrahedronModel which is now in a plugin. A cmake defined variable is used to unactive this part of the code for the moment.
…e able to create and run a scene without xml file.
…on outputs. This code is deprecated, to handle volumetric rendering, use the plugin: VolumetricRendering
…store a pointer to the class SofaPhysicsSimulation instead. This is done to easily inherite from SofaPhysicsAPI.
…lation.h as it is not a impl subclass anymore. Set some methods in virtual for inheritence and add accessor to rootNode.
@epernod epernod added the issue: bug (major) Critical bug affecting everyone: not working, performances or accuracy degraded label Feb 10, 2017
@epernod epernod added this to the v17.06 milestone Feb 10, 2017
@guparan guparan added pr: fix Fix a bug and removed issue: bug (major) Critical bug affecting everyone: not working, performances or accuracy degraded labels Feb 15, 2017
@hugtalbot
Copy link
Contributor

Hi @epernod

you PR has a conflict, could you resolve it ?
Cheers,

Hugo

Conflicts:
	applications/projects/SofaPhysicsAPI/SofaPhysicsOutputMesh_Tetrahedron.cpp
	applications/projects/SofaPhysicsAPI/SofaPhysicsOutputMesh_Tetrahedron_impl.h
@damienmarchal
Copy link
Contributor

[ci-build]

@matthieu-nesme matthieu-nesme merged commit 5d8d5a5 into sofa-framework:master Mar 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: fix Fix a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants