-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MultiThreading] Parallel BVH narrow phase #2053
Merged
hugtalbot
merged 21 commits into
sofa-framework:master
from
alxbilger:parallel_narrow_phase
May 10, 2021
Merged
[MultiThreading] Parallel BVH narrow phase #2053
hugtalbot
merged 21 commits into
sofa-framework:master
from
alxbilger:parallel_narrow_phase
May 10, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aceDetection RayTraceDetection inherits from BruteForceBroadPhase. It makes more sense because the broad phase of RayTraceDetection was actually a brute force broad phase.
The component is a parallel implementation of BruteForceBroadPhase
…ction into a new component
alxbilger
added
pr: new feature
Implement a new feature
pr: status to review
To notify reviewers to review this pull-request
labels
Apr 29, 2021
[ci-build][with-all-tests] |
hugtalbot
added
pr: status ready
Approved a pull-request, ready to be squashed
and removed
pr: status to review
To notify reviewers to review this pull-request
labels
May 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr: new feature
Implement a new feature
pr: status ready
Approved a pull-request, ready to be squashed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #2043
A new component is introduced:
ParallelBVHNarrowPhase
. As the name suggests, it is the parallel implementation ofBVHNarrowPhase
.Details
The broad phase provides a list of pairs of collision models. In the initial
BVHNarrowPhase
component, the list was processed sequentially. InParallelBVHNarrowPhase
each pair is processed in a task, which is given to a thread pool.Note that the traversal of the bounding volume hierarchy is not parallel. It is still single threaded.
Due to race conditions, some operations must be done prior to the parallel tasks:
Results
The tested scene is
applications/plugins/MultiThreading/examples/ParallelBruteForceBroadPhase.scn
during 500 time steps.The narrow phase duration has been measured with
ParallelBVHNarrowPhase
compared toBVHNarrowPhase
.By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if