Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SofaBaseMechanics] MechanicalObject: cleaning (symbols & include) #249

Merged
merged 3 commits into from
Apr 27, 2017
Merged

[SofaBaseMechanics] MechanicalObject: cleaning (symbols & include) #249

merged 3 commits into from
Apr 27, 2017

Conversation

fredroy
Copy link
Contributor

@fredroy fredroy commented Apr 20, 2017 •
edited by damienmarchal
Loading

Small PR to :

  • remove useless header (and then remove one dependency on SofaBaseTopology) (see discussion MechanicalObject : dependency to TopologyData #242 ) (actually instead of removing, I used an existing #ifdef macro)
  • add forgotten Windows macro to export specialized functions into DLLs

This should not break any API compatibility or compilation (hopefully)

This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings nor unit test failures.
  • does not break existing scenes.
  • does not break API compatibility.
  • has been reviewed.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@fredroy
[SofaBaseMechanics] MechanicalObject: remove useless header + add for…
9d9735e 
…gotten windows macro to export symbols into dlls
@fredroy fredroy assigned bcarrez and unassigned bcarrez Apr 20, 2017
@fredroy fredroy assigned fredroy, bcarrez and hugtalbot and unassigned fredroy and bcarrez Apr 20, 2017
@guparan guparan added the pr: status ready Approved a pull-request, ready to be squashed label Apr 26, 2017
@guparan guparan merged commit 2274448 into sofa-framework:master Apr 27, 2017
@guparan guparan added pr: clean Cleaning the code and removed pr: fix Fix a bug labels Jun 29, 2017
@guparan guparan added this to the v17.06 milestone Jun 29, 2017
@fredroy fredroy deleted the misc_mechanicalobj branch September 14, 2017 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@hugtalbot hugtalbot

Labels
pr: clean Cleaning the code pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v17.06
Development

Successfully merging this pull request may close these issues.
4 participants
@fredroy @guparan @hugtalbot @bcarrez