Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[all] Message cleaning week23 #339

Merged
merged 6 commits into from
Jul 27, 2017
Merged

[all] Message cleaning week23 #339

merged 6 commits into from
Jul 27, 2017

Conversation

damienmarchal
Copy link
Contributor

@damienmarchal damienmarchal commented Jul 20, 2017 •
edited
Loading

In this PR I do only cleaning:
- replace a bunch of std::cerr, std::cout, prinf to use msg_* instead.
- remove commented code

If I didn't made mistake nothing should break.

CHANGELOG:
[all]:

  • remove a lot of commented code.
  • replace std:cerr, std::cout and printf with msg_*

This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@damienmarchal
[SofaKernel/framework] replace std::cerr/std::cout with msg_*
c9f78d0
@damienmarchal
Merge remote-tracking branch 'upstream/master' into message_cleaning_…
a9a394a 
…week23

# Conflicts:
#	SofaKernel/framework/sofa/helper/logging/Message.cpp
#	SofaKernel/framework/sofa/helper/logging/Message.h
@damienmarchal
[all] One more cleaning commit in which I remove std::cerr
a42dcec 
I did my best no to break anything.

Signed-off-by: Damien Marchal <damien.marchal@univ-lille1.fr>
@damienmarchal
[all] Replace printf & std::cerr with the right msg_*
7734cbf
@damienmarchal
[SofaKernel] Factor some code related to messaging.
7efff41 
Signed-off-by: Damien Marchal <damien.marchal@univ-lille1.fr>
@damienmarchal damienmarchal added pr: clean Cleaning the code project: UX pr: status to review To notify reviewers to review this pull-request labels Jul 20, 2017
@hugtalbot hugtalbot self-assigned this Jul 26, 2017
@hugtalbot hugtalbot added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Jul 26, 2017
@guparan guparan merged commit a7b04cc into sofa-framework:master Jul 27, 2017
@hugtalbot
Copy link
Contributor

could you provide me some info for the Changelog @damienmarchal please ?

@damienmarchal damienmarchal deleted the message_cleaning_week23 branch August 22, 2017 13:05
@guparan guparan modified the milestones: v17.06, v17.12 Sep 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@hugtalbot hugtalbot

Labels
pr: clean Cleaning the code pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v17.12
Development

Successfully merging this pull request may close these issues.
3 participants
@damienmarchal @hugtalbot @guparan