Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SofaKernel] fix TetrahedronFEMForceField #341

Merged
merged 1 commit into from
Jul 27, 2017
Merged

[SofaKernel] fix TetrahedronFEMForceField #341

merged 1 commit into from
Jul 27, 2017

Conversation

EulalieCoevoet
Copy link
Contributor

@EulalieCoevoet EulalieCoevoet commented Jul 20, 2017 •
edited by guparan
Loading

I think "_rotationIdx" should have the size of the number of points.
The problem occured when using subtopology, i.e when the number of points is greater than nbElements*4...

This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@EulalieCoevoet EulalieCoevoet added pr: fix Fix a bug pr: status to review To notify reviewers to review this pull-request labels Jul 20, 2017
@hugtalbot
Copy link
Contributor

[ci-build]

@hugtalbot hugtalbot added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Jul 24, 2017
@hugtalbot
Copy link
Contributor

build and merge

@hugtalbot hugtalbot self-assigned this Jul 24, 2017
@damienmarchal
Copy link
Contributor

[ci-build]

@guparan guparan merged commit 1921aea into sofa-framework:master Jul 27, 2017
matthieu-nesme pushed a commit to Anatoscope/sofa that referenced this pull request Aug 4, 2017
@guparan @matthieu-nesme
Merge pull request sofa-framework#341 from SofaDefrost/fixTetrahedron…
a0b5be0 
…FEMFF

[SofaKernel] fix TetrahedronFEMForceField
(cherry picked from commit 1921aea)
@EulalieCoevoet EulalieCoevoet deleted the fixTetrahedronFEMFF branch August 18, 2017 16:53
@guparan guparan modified the milestones: v17.06, v17.12 Sep 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@hugtalbot hugtalbot

Labels
pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v17.12
Development

Successfully merging this pull request may close these issues.
4 participants
@EulalieCoevoet @hugtalbot @damienmarchal @guparan