Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SofaGeneralEngine] FIX some XyzTransformMatrixEngine::update() function #343

Merged

Conversation

thomas-lemaire
Copy link
Contributor

@thomas-lemaire thomas-lemaire commented Jul 20, 2017

rapid fix


This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@thomas-lemaire thomas-lemaire added pr: fix Fix a bug pr: status to review To notify reviewers to review this pull-request labels Jul 20, 2017
@hugtalbot hugtalbot added the pr: fast merge Minor change that can be merged without waiting for the 7 review days label Jul 24, 2017
@hugtalbot hugtalbot self-assigned this Jul 24, 2017
@hugtalbot hugtalbot added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Jul 24, 2017
@hugtalbot hugtalbot merged commit c04893e into sofa-framework:master Jul 26, 2017
@guparan guparan modified the milestones: v17.06, v17.12 Sep 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants