Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[all] More std::cout to msg_* cleaning #370

Merged
merged 6 commits into from
Aug 30, 2017

Conversation

damienmarchal
Copy link
Contributor

@damienmarchal damienmarchal commented Aug 21, 2017

This is the Defrost cleaning week29 with...as usual a lot of std:cout and dead code removal.
Shouldn't break anything.
In case some component are too verbose please tell us.


This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@damienmarchal damienmarchal added pr: clean Cleaning the code pr: status to review To notify reviewers to review this pull-request labels Aug 21, 2017
@guparan
Copy link
Contributor

guparan commented Aug 28, 2017

Thank you @SofaDefrost for these cleaning PRs.
LGTM, mainly by reading CI results though since it's quite hard to review such a massive diff.

@guparan guparan added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Aug 30, 2017
@hugtalbot hugtalbot merged commit fb65eb5 into sofa-framework:master Aug 30, 2017
@damienmarchal damienmarchal deleted the defrost_cleaning_week29 branch September 6, 2017 14:51
@guparan guparan modified the milestones: v17.06, v17.12 Sep 13, 2017
@guparan guparan changed the title [all] Yet Another std::cout to msg_* cleaning batch. [all] More std::cout to msg_* cleaning Dec 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: clean Cleaning the code pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants