[SofaKernel] FIX CreateString problem on root node #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the source path is from the root the path is empty. This results in returning @ instead of @/ This fix it.
damienmarchal
added
pr: fast merge
This was referenced Aug 25, 2017
hugtalbot
approved these changes
Aug 31, 2017
hugtalbot
added
pr: status ready
|
[ci-build] |
matthieu-nesme
pushed a commit
to Anatoscope/sofa
that referenced
this pull request
Sep 6, 2017
…nkpath [SofaKernel] FIX CreateString problem on root node (cherry picked from commit 83afb07)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the source path is from the root the path is empty.
This results in returning @ instead of @/
This fix it.
This fix issue #375
This is a reviewer friendly version of #376
This PR:
Reviewers will merge only if all these checks are true.