-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SofaVolumetricData] Split the module into multiple plugin #389
[SofaVolumetricData] Split the module into multiple plugin #389
Conversation
This is the beginning of a work on cleaning and modularizing the SofaVolumetricData. The module is splitted in two Plugins. - SofaDistanceGrid - SofaImplicitField A third plugin act as a transitional package SofaVolumetricData guiding other developpers on the change they have to do in order to have their code compiling again.
Hi guys... OMG no one answered in 5 days !! |
Is there a removal date for the third plugin ? (To force developers to make the changes) |
@untereiner thank for the question. What I would dream of some kind of consensus about how we proceed and I'm totally open for suggestions. I see the goods of making smooth transition in a code base (user of the code base will praise you) and the bad of maintaining the transitional package. On my side... I would say:
|
Hi @damienmarchal, thank you for this massive work. |
I agree with you but to avoid calendar issues I would speak rather in term of release: Two releases for the transition and remove at the third one. |
Thanks you all the for the feedback. I appologize about the reviewing work. And you are right, this one is very hard. We can also be a bit more "lazy" in the reviewing, merging it, write a good changelog a tell people to send feedback if something goes wrong. I'm pushing this one because we have a nice other PR waiting and this one have new cool features (from distance field modeling to tetrahedral meshing). EDIT: actually moving from module to plugins without refactoring is much easier...but well... I was not able to prevent me. |
Not ready ? |
…icDataSquashed # Conflicts: # applications/plugins/CMakeLists.txt # modules/SofaComponentAdvanced/CMakeLists.txt # modules/SofaVolumetricData/InterpolatedImplicitSurface.cpp # modules/tests/CMakeLists.txt
Let's see if it really builds ;-) |
Thanks for spotting that... can you do the same for the others plugnization ? |
I did, the plugins are activated by default in the others. |
[ci-build] to take into account the last merge. |
[ci-build] |
This PR is here to support Issue #388
This is the beginning of a work on cleaning and modularizing the
SofaVolumetricData.
The module is splitted in two Plugins.
A third plugin act as a transitional package SofaVolumetricData guiding
other developpers on the change they have to do in order to have their
code compiling again.
CHANGELOG.txt:
This PR:
Reviewers will merge only if all these checks are true.