Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SceneChecker] Fix the test that was wrong and thus failing. #405

Merged
merged 1 commit into from
Sep 18, 2017
Merged

[SceneChecker] Fix the test that was wrong and thus failing. #405

merged 1 commit into from
Sep 18, 2017

Conversation

damienmarchal
Copy link
Contributor

@damienmarchal damienmarchal commented Sep 15, 2017 •
edited by guparan
Loading

Everything is is in the title. The test was wrong.

This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@damienmarchal damienmarchal added pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: fix Fix a bug pr: status to review To notify reviewers to review this pull-request labels Sep 15, 2017
@damienmarchal damienmarchal mentioned this pull request Sep 18, 2017
Merged
6 tasks
@guparan guparan added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Sep 18, 2017
@damienmarchal
Copy link
Contributor Author

Thank you for the review... can we merge it ?

@guparan
Copy link
Contributor

guparan commented Sep 18, 2017

I just passed it to ready waiting for our beloved CI to do its work...

@damienmarchal
Copy link
Contributor Author

Our beloved CI answered :)

@guparan guparan merged commit 6f70b12 into sofa-framework:master Sep 18, 2017
@damienmarchal damienmarchal deleted the fixSceneCheckerTest branch September 20, 2017 18:32
@guparan guparan added this to the v17.12 milestone Dec 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guparan guparan guparan approved these changes

Assignees

@guparan guparan

Labels
pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v17.12
Development

Successfully merging this pull request may close these issues.
2 participants
@damienmarchal @guparan