[Geometry] Update method intersectionWithEdge signature and redirect all methods to it in EdgeSetGeometryAlgorithms

[epernod]

• [Geometry] Update method signature of intersectionWithEdge to pass barycentric coordinates instead of 3D coord.
• [Topology.Container] Update all method compute2EdgesIntersection to use the generic method in Edge class

---

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

---

Reviewers will merge this pull-request only if

• it builds with SUCCESS for all platforms on the CI.
• it does not generate new warnings.
• it does not generate new unit test failures.
• it does not generate new scene test failures.
• it does not break API compatibility.
• it is more than 1 week old (or has fast-merge label).

[epernod]

[ci-build][with-all-tests]

[fredroy]

getCPos() returns a const reference
and i did not see the need to cast ? 🧐

[fredroy]

[ci-build][with-all-tests]

[fredroy]

A unit test is failing, in Sofa.Component.Topology/InciseProcessor_test.InciseTriangles
from TriangleSetGeometryAlgorithms: Orthogonal projection failed

[hugtalbot]

Still a unit test failing @epernod

[epernod]

[ci-build][with-all-tests]

[hugtalbot]

the rebase did not suffice @epernod
we let it to review but a unit test is still failing

[epernod]

Last regression test failing will disappear as soon as PR #4494 is merged as the new version of isquadDelaunay method is not using this method intersectionWithEdge anymore.
And for the note, the error is a false positive. The regression should be regenerated at one point.

[fredroy]

Last regression test failing will disappear as soon as PR #4494 is merged as the new version of isquadDelaunay method is not using this method intersectionWithEdge anymore. And for the note, the error is a false positive. The regression should be regenerated at one point.

Regressions are OK but the error being an unit test InciseProcessor_test.InciseTriangles, it is because of [ERROR] [TriangleSetGeometryAlgorithms(GeomAlgo)] Orthogonal projection failed
I dont really see how it can be a false positive ?

[epernod]

can you point the test that is not wworking, it is impossible to find it in jenkins menu, even more with a low bandwidth

[fredroy]

can you point the test that is not wworking, it is impossible to find it in jenkins menu, even more with a low bandwidth

Regressions are OK but the error being an unit test InciseProcessor_test.InciseTriangles, it is because of [ERROR] [TriangleSetGeometryAlgorithms(GeomAlgo)] Orthogonal projection failed I dont really see how it can be a false positive ?

InciseProcessor_test.InciseTriangles 😅 ?

sofa/Sofa/Component/Topology/Utility/tests/TopologicalChangeProcessor_test.cpp

Line 362 in 251fd89

TEST_F(InciseProcessor_test, InciseTriangles)

But for sure the CI jenkins is slow as hell

[epernod]

Last regression test failing will disappear as soon as PR #4494 is merged as the new version of isquadDelaunay method is not using this method intersectionWithEdge anymore. And for the note, the error is a false positive. The regression should be regenerated at one point.

Regressions are OK but the error being an unit test InciseProcessor_test.InciseTriangles, it is because of [ERROR] [TriangleSetGeometryAlgorithms(GeomAlgo)] Orthogonal projection failed I dont really see how it can be a false positive ?

Hi,
I meant, false positive because it is part of the snapping algorithm in the incision which was already buggy but the error was not catch before.
The projection was computed totally outside of the edge (the mesh is a square of size 10x10:
coord_edge1: [5.44854, 5.02682, -0.832787] - [4.86141, 4.79438, -0.760481]
coord_edge2: [4.99791, 4.99949, -0.778808] - [20676.1, 52846.7, 1933.72]

the result was a strange (but not crashing 🤔 ) incision

In fact the correct fix is to exit the snapping if the projection failed and continue the incision normally instead of forcing the projection and use a "random" point of the triangle to be snapped.

Here is the result after:

[epernod]

[ci-build][with-all-tests]