Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Helper] Update ComponentChange for MechanicalMatrixMapper #4235

Merged
merged 1 commit into from
Oct 16, 2023
Merged

[Helper] Update ComponentChange for MechanicalMatrixMapper #4235

merged 1 commit into from
Oct 16, 2023

Conversation

alxbilger
Copy link
Contributor

and MappingGeometricStiffnessForceField

The message goes from:

Object type MechanicalMatrixMapper<Vec3d,Vec3d> was not created
The object 'MechanicalMatrixMapper' is not in the factory.
This component has been MOVED from SofaGeneralAnimationLoop to Sofa.Component.Mapping.MappedMatrix since SOFA v22.06.
To continue using this component you may need to update your scene by adding
<RequiredPlugin name='Sofa.Component.Mapping.MappedMatrix'/>

to:

The object 'MechanicalMatrixMapper' is not in the factory.
This component has been REMOVED since SOFA v23.06 (deprecated since v23.12).
Please consider updating your scene. If this component is crucial to you please report in a GitHub issue in order to reconsider this component for future re-integration.

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@alxbilger
[Helper] Update ComponentChange for MechanicalMatrixMapper
84bea9d 
and MappingGeometricStiffnessForceField

The message goes from:
```
Object type MechanicalMatrixMapper<Vec3d,Vec3d> was not created
The object 'MechanicalMatrixMapper' is not in the factory.
This component has been MOVED from SofaGeneralAnimationLoop to Sofa.Component.Mapping.MappedMatrix since SOFA v22.06.
To continue using this component you may need to update your scene by adding
<RequiredPlugin name='Sofa.Component.Mapping.MappedMatrix'/>
```

to:

```
The object 'MechanicalMatrixMapper' is not in the factory.
This component has been REMOVED since SOFA v23.06 (deprecated since v23.12).
Please consider updating your scene. If this component is crucial to you please report in a GitHub issue in order to reconsider this component for future re-integration.
```
@alxbilger alxbilger added pr: fix Fix a bug pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status to review To notify reviewers to review this pull-request labels Oct 16, 2023
@alxbilger
Copy link
Contributor Author

[ci-build][with-all-tests]

@bakpaul bakpaul merged commit 5433100 into sofa-framework:master Oct 16, 2023
5 checks passed
@hugtalbot hugtalbot added this to the v23.12 milestone Nov 29, 2023
@hugtalbot hugtalbot added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bakpaul bakpaul bakpaul approved these changes

Assignees
No one assigned
Labels
pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v23.12
Development

Successfully merging this pull request may close these issues.
3 participants
@alxbilger @bakpaul @hugtalbot