Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SofaCUDA] Dont use both version of cublas (legacy or v2) #4274

Merged
merged 2 commits into from
Nov 8, 2023

Conversation

fredroy
Copy link
Contributor

@fredroy fredroy commented Nov 1, 2023

(just randomly enabled SOFA_GPU_CUBLAS 😅)

Starting from CUDA12, you cannot include both cublas.h and cublas_v2.h (throw a compilation error)

There is apparently no code using the functions enabled by SOFA_GPU_CUBLAS so nothing to test against...

Reference:
https://docs.nvidia.com/cuda/cublas/index.html

Starting with version 4.0, the cuBLAS Library provides a new API, in addition to the existing legacy API. This section discusses why a new API is provided, the advantages of using it, and the differences with the existing legacy API.
Warning
The legacy cuBLAS API is deprecated and will be removed in future release.

and CUDA4 was released in early 2011, so I may think we could throw the legacy support away...


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@fredroy fredroy added pr: fix Fix a bug pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status to review To notify reviewers to review this pull-request labels Nov 1, 2023
@bakpaul bakpaul removed the pr: fast merge Minor change that can be merged without waiting for the 7 review days label Nov 2, 2023
@epernod
Copy link
Contributor

epernod commented Nov 3, 2023

(just randomly enabled SOFA_GPU_CUBLAS 😅)

Starting from CUDA12, you cannot include both cublas.h and cublas.h (throw a compilation error)

I supposed you meant cublas.h and cublas_v2.h or my eyes are not yet totally recovered.

Copy link
Contributor

@epernod epernod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

total trust 🙈

@fredroy
Copy link
Contributor Author

fredroy commented Nov 5, 2023

(just randomly enabled SOFA_GPU_CUBLAS 😅)
Starting from CUDA12, you cannot include both cublas.h and cublas.h (throw a compilation error)

I supposed you meant cublas.h and cublas_v2.h or my eyes are not yet totally recovered.

😅 yes

@hugtalbot hugtalbot added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Nov 8, 2023
@epernod epernod merged commit c00d082 into sofa-framework:master Nov 8, 2023
2 checks passed
@hugtalbot hugtalbot added this to the v23.12 milestone Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants