Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SofaAssimp] Fix the FindAssimp.cmake #4326

Merged
merged 4 commits into from
Feb 15, 2024
Merged

[SofaAssimp] Fix the FindAssimp.cmake #4326

merged 4 commits into from
Feb 15, 2024

Conversation

bakpaul
Copy link
Contributor

@bakpaul bakpaul commented Nov 30, 2023

Fix the FindAssimp.cmake by changing variable set by assimp to new names.

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@hugtalbot hugtalbot changed the title [SofaAssimp] Fix Findassimp [SofaAssimp] Fix the FindAssimp.cmake Nov 30, 2023
@hugtalbot hugtalbot added pr: fix Fix a bug pr: status to review To notify reviewers to review this pull-request labels Nov 30, 2023
@hugtalbot
Copy link
Contributor

[ci-build]

@bakpaul
Copy link
Contributor Author

bakpaul commented Dec 1, 2023

It currently works fine with the new windows builder. So it will be ready when new builder are up

@bakpaul bakpaul added the pr: backport todo This PR will be backported into the release preceeding its milestone. label Jan 22, 2024
@bakpaul bakpaul merged commit 8f45a1e into sofa-framework:master Feb 15, 2024
3 checks passed
bakpaul added a commit that referenced this pull request Feb 19, 2024
@bakpaul
[SofaAssimp] Fix the FindAssimp.cmake (#4326)
7545784 
Fix Findassimp
@bakpaul bakpaul added this to the v23.12 milestone Feb 20, 2024
@bakpaul bakpaul added pr: backport done This PR has been backported into the release before its milestone. and removed pr: backport todo This PR will be backported into the release preceeding its milestone. labels Feb 20, 2024
@hugtalbot hugtalbot added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugtalbot hugtalbot hugtalbot approved these changes

@fredroy fredroy fredroy approved these changes

Assignees
No one assigned
Labels
pr: backport done This PR has been backported into the release before its milestone. pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v23.12
Development

Successfully merging this pull request may close these issues.
3 participants
@bakpaul @hugtalbot @fredroy