Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Config] CMake: support interface-type target for install macro #4356

Merged
merged 5 commits into from
Dec 20, 2023
Merged

[Config] CMake: support interface-type target for install macro #4356

merged 5 commits into from
Dec 20, 2023

Conversation

fredroy
Copy link
Contributor

@fredroy fredroy commented Dec 13, 2023 •
edited
Loading

... when AUTO_SET_TARGET_PROPERTIES is set

(useful for external header-only targets)

EDIT: a lot of cases will be handled in cmake >3.24 a(avoiding lots of tests)

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@fredroy fredroy added enhancement About a possible enhancement pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status to review To notify reviewers to review this pull-request labels Dec 13, 2023
@fredroy fredroy mentioned this pull request Dec 13, 2023
Merged
@fredroy fredroy removed the pr: fast merge Minor change that can be merged without waiting for the 7 review days label Dec 13, 2023
@fredroy @bakpaul
Update Sofa/framework/Config/cmake/SofaMacrosInstall.cmake
4119d24 
Co-authored-by: Paul Baksic <30337881+bakpaul@users.noreply.github.com>
@hugtalbot hugtalbot added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Dec 20, 2023
@epernod epernod merged commit 357929d into sofa-framework:master Dec 20, 2023
10 checks passed
@fredroy fredroy deleted the update_macro_install_for_interface branch January 7, 2024 23:40
@hugtalbot hugtalbot added pr: backport todo This PR will be backported into the release preceeding its milestone. and removed pr: backport todo This PR will be backported into the release preceeding its milestone. labels Jan 10, 2024
@hugtalbot hugtalbot added this to the v24.06 milestone Jan 10, 2024
hugtalbot pushed a commit to hugtalbot/sofa that referenced this pull request Jan 16, 2024
@fredroy @hugtalbot
[Config] CMake: support interface-type target for install macro (sofa…
6378524 
…-framework#4356)

* support interface-type for auto_target_properties install macro

* try updating install macro

* try updating install macro again

* Update Sofa/framework/Config/cmake/SofaMacrosInstall.cmake
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bakpaul bakpaul bakpaul approved these changes

Assignees
No one assigned
Labels
enhancement About a possible enhancement pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v24.06
Development

Successfully merging this pull request may close these issues.
4 participants
@fredroy @bakpaul @hugtalbot @epernod