Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Topology.Mapping] Edge2QuadTopologicalMapping: use States directly #4388

Merged
merged 3 commits into from
Dec 27, 2023

Conversation

fredroy
Copy link
Contributor

@fredroy fredroy commented Dec 18, 2023

Based on

diff: https://github.com/fredroy/sofa/compare/geoalgo_states..edge2quad_state

No need to pass by a intermediary MechanicalObject anymore (+subsequent Mapping as well)

Avoids:

  • using mechanical mappings for visual mappings (no useless applyJ/applyJT calls)
  • to call an other mapping as well
  • setting the (not doing its purpose) isMechanical flag

  • With the example (Edge2QuadTopologicalMapping.scn)

with GUI (glfw)

master 10000 iterations done in 20.618 s ( 485.013 FPS)
pr     10000 iterations done in 16.601 s ( 602.373 FPS)

no GUI (batch)

master 10000 iterations done in 17.3933 s ( 574.935 FPS)
pr     10000 iterations done in 13.6906 s ( 730.43 FPS)
  • With [modified] BeamAdapter's scene (with gui)
master 5000 iterations done in 35.184 s ( 142.11 FPS)
pr     5000 iterations done in 29.48 s ( 169.607 FPS)

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@fredroy fredroy added enhancement About a possible enhancement pr: status to review To notify reviewers to review this pull-request labels Dec 18, 2023
@fredroy
Copy link
Contributor Author

fredroy commented Dec 18, 2023

[ci-build][with-all-tests]

@hugtalbot hugtalbot added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Dec 20, 2023
@epernod epernod merged commit 32d5e29 into sofa-framework:master Dec 27, 2023
11 checks passed
@fredroy fredroy deleted the edge2quad_state branch January 7, 2024 23:40
@hugtalbot hugtalbot added pr: backport todo This PR will be backported into the release preceeding its milestone. and removed pr: backport todo This PR will be backported into the release preceeding its milestone. labels Jan 10, 2024
@hugtalbot hugtalbot added this to the v24.06 milestone Jan 10, 2024
hugtalbot pushed a commit to hugtalbot/sofa that referenced this pull request Jan 16, 2024
…ofa-framework#4388)

* use directly states for edge2quad

* apply to example scene

* clean/format includes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement About a possible enhancement pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants