[Constraint.Lagrangian.Solver] Fix assert in GenericConstraintSolver #4389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alxbilger
added
pr: fix
|
[ci-build][with-all-tests] |
fredroy
reviewed
Dec 20, 2023
| @@ -141,7 +141,7 @@ class SOFA_COMPONENT_CONSTRAINT_LAGRANGIAN_SOLVER_API GenericConstraintSolver : | |||
| void computeAndApplyMotionCorrection(const core::ConstraintParams* cParams, GenericConstraintSolver::MultiVecId res1, GenericConstraintSolver::MultiVecId res2) const; | |||
| void applyMotionCorrection( | |||
| const core::ConstraintParams* cParams, | |||
| const core::MultiVecCoordId xId, | |||
| const std::unique_ptr<core::MultiVecCoordId>& xId, | |||
There was a problem hiding this comment.
change of API so breaking 😶🌫️
There was a problem hiding this comment.
The function is private. Do you see a case where changing the signature of a private method can be breaking?
There was a problem hiding this comment.
hum if somebody inherits it ? (and override it)
alxbilger
commented
Dec 20, 2023
.../Lagrangian/Solver/src/sofa/component/constraint/lagrangian/solver/GenericConstraintSolver.h
Outdated
Show resolved
Hide resolved
bakpaul
approved these changes
Jan 3, 2024
bakpaul
added
pr: status ready
The construction of xId caused an assert when `cParams->constOrder() == sofa::core::ConstraintOrder::VEL`. It happens only in debug, and it had no consequence because it was not used.
|
[ci-build][with-all-tests][force-full-build] |
hugtalbot
added
pr: backport todo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The construction of xId caused an assert when
cParams->constOrder() == sofa::core::ConstraintOrder::VEL. It happens only in debug, and it had no consequence because it was not used.Bug introduced in #4213
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if