Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SofaSimpleGUI] Fix calls to deprecated functions #4390

Merged
merged 1 commit into from
Dec 21, 2023
Merged

[SofaSimpleGUI] Fix calls to deprecated functions #4390

merged 1 commit into from
Dec 21, 2023

Conversation

alxbilger
Copy link
Contributor

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@alxbilger alxbilger added pr: status to review To notify reviewers to review this pull-request pr: clean Cleaning the code deprecated About a deprecated code labels Dec 18, 2023
@alxbilger
Copy link
Contributor Author

[ci-build][with-all-tests]

@fredroy fredroy added the pr: fast merge Minor change that can be merged without waiting for the 7 review days label Dec 20, 2023
@hugtalbot hugtalbot added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Dec 20, 2023
@fredroy fredroy merged commit 42a96f9 into sofa-framework:master Dec 21, 2023
11 checks passed
@hugtalbot hugtalbot added pr: backport todo This PR will be backported into the release preceeding its milestone. and removed pr: backport todo This PR will be backported into the release preceeding its milestone. labels Jan 10, 2024
@hugtalbot hugtalbot added this to the v24.06 milestone Jan 10, 2024
hugtalbot pushed a commit to hugtalbot/sofa that referenced this pull request Jan 16, 2024
@alxbilger @hugtalbot
[SofaSimpleGUI] Fix calls to deprecated functions (sofa-framework#4390)
19b3519
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bakpaul bakpaul bakpaul approved these changes

@hugtalbot hugtalbot hugtalbot approved these changes

Assignees
No one assigned
Labels
deprecated About a deprecated code pr: clean Cleaning the code pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v24.06
Development

Successfully merging this pull request may close these issues.
4 participants
@alxbilger @hugtalbot @bakpaul @fredroy