Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Type] Remove test of a deprecated constructor #4391

Merged
merged 1 commit into from
Dec 19, 2023
Merged

[Type] Remove test of a deprecated constructor #4391

merged 1 commit into from
Dec 19, 2023

Conversation

alxbilger
Copy link
Contributor

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@alxbilger alxbilger added pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status to review To notify reviewers to review this pull-request pr: clean Cleaning the code labels Dec 18, 2023
@alxbilger alxbilger force-pushed the removedeprecatedtest branch from 199dba1 to f2a367a Compare December 18, 2023 10:54
@fredroy fredroy force-pushed the removedeprecatedtest branch from f2a367a to 11996e7 Compare December 18, 2023 23:36
@fredroy fredroy added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Dec 19, 2023
@fredroy fredroy merged commit beb3251 into sofa-framework:master Dec 19, 2023
12 checks passed
fredroy pushed a commit to fredroy/sofa that referenced this pull request Dec 21, 2023
@alxbilger @fredroy
[Type] Remove test of a deprecated constructor (sofa-framework#4391)
92b4586
@hugtalbot hugtalbot added pr: backport todo This PR will be backported into the release preceeding its milestone. and removed pr: backport todo This PR will be backported into the release preceeding its milestone. labels Jan 10, 2024
@hugtalbot hugtalbot added this to the v24.06 milestone Jan 10, 2024
hugtalbot pushed a commit to hugtalbot/sofa that referenced this pull request Jan 16, 2024
@alxbilger @hugtalbot
[Type] Remove test of a deprecated constructor (sofa-framework#4391)
3f434ed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredroy fredroy fredroy approved these changes

Assignees
No one assigned
Labels
pr: clean Cleaning the code pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v24.06
Development

Successfully merging this pull request may close these issues.
3 participants
@alxbilger @fredroy @hugtalbot