Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MultiThreading] Fix failing test on ParallelImplementationsRegistry #4392

Merged
merged 2 commits into from
Dec 19, 2023
Merged

[MultiThreading] Fix failing test on ParallelImplementationsRegistry #4392

merged 2 commits into from
Dec 19, 2023

Conversation

alxbilger
Copy link
Contributor

@alxbilger alxbilger commented Dec 18, 2023 •
edited
Loading

Fixes #4323

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@alxbilger alxbilger added the pr: status to review To notify reviewers to review this pull-request label Dec 18, 2023
@alxbilger alxbilger changed the title Investigate failing test on ParallelImplementationsRegistry [MultiThreading] Investigate failing test on ParallelImplementationsRegistry Dec 18, 2023
@alxbilger alxbilger changed the title [MultiThreading] Investigate failing test on ParallelImplementationsRegistry [MultiThreading] Fix failing test on ParallelImplementationsRegistry Dec 18, 2023
@alxbilger alxbilger marked this pull request as ready for review December 18, 2023 14:34
@alxbilger alxbilger added pr: fix Fix a bug pr: fast merge Minor change that can be merged without waiting for the 7 review days labels Dec 18, 2023
@fredroy fredroy added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Dec 19, 2023
@fredroy fredroy merged commit 27878bd into sofa-framework:master Dec 19, 2023
12 checks passed
fredroy pushed a commit to fredroy/sofa that referenced this pull request Dec 21, 2023
@alxbilger @fredroy
[MultiThreading] Fix failing test on ParallelImplementationsRegistry (s…
94d07c9 
…ofa-framework#4392)

* More details when test fails

* Test initializing the module at init
@hugtalbot hugtalbot added pr: backport todo This PR will be backported into the release preceeding its milestone. and removed pr: backport todo This PR will be backported into the release preceeding its milestone. labels Jan 10, 2024
@hugtalbot hugtalbot added this to the v24.06 milestone Jan 10, 2024
hugtalbot pushed a commit to hugtalbot/sofa that referenced this pull request Jan 16, 2024
@alxbilger @hugtalbot
[MultiThreading] Fix failing test on ParallelImplementationsRegistry (s…
ac79c34 
…ofa-framework#4392)

* More details when test fails

* Test initializing the module at init
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v24.06
Development

Successfully merging this pull request may close these issues.

Multithread Unit test falling
3 participants
@alxbilger @fredroy @hugtalbot