-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VolumetricRendering] Fix the compilation #4398
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
But scenes crash
alxbilger
added
pr: fix
Fix a bug
pr: status to review
To notify reviewers to review this pull-request
labels
Dec 20, 2023
@fredroy thanks for the PR but I still crash in |
@fredroy Yeah! The scene no longer crashes! But I have the following errors:
I guess the shaders needs to be updated for version >= 140 |
fredroy
added
pr: status ready
Approved a pull-request, ready to be squashed
and removed
pr: status to review
To notify reviewers to review this pull-request
labels
Jan 3, 2024
hugtalbot
added
pr: backport todo
This PR will be backported into the release preceeding its milestone.
and removed
pr: backport todo
This PR will be backported into the release preceeding its milestone.
labels
Jan 10, 2024
hugtalbot
added
the
pr: backport todo
This PR will be backported into the release preceeding its milestone.
label
Feb 19, 2024
bakpaul
added
pr: backport done
This PR has been backported into the release before its milestone.
and removed
pr: backport todo
This PR will be backported into the release preceeding its milestone.
labels
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr: backport done
This PR has been backported into the release before its milestone.
pr: fix
Fix a bug
pr: status ready
Approved a pull-request, ready to be squashed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
But scenes crash
Before going further with #4395, it is wiser to first fix the compilation of the plugin. We can even wonder if we keep this plugin since it has not been maintained for a while.
Note that this plugin is not compiled on the CI. See sofa-framework/ci#32
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if