Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RigidMapping: fixed setRepartition backward compatibility #441

Merged
merged 2 commits into from
Oct 26, 2017
Merged

RigidMapping: fixed setRepartition backward compatibility #441

merged 2 commits into from
Oct 26, 2017

Conversation

matthieu-nesme
Copy link
Member

@matthieu-nesme matthieu-nesme commented Oct 4, 2017 •
edited by guparan
Loading

fixes #435 RigidMapping

This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@matthieu-nesme matthieu-nesme added pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: fix Fix a bug labels Oct 4, 2017
@matthieu-nesme matthieu-nesme mentioned this pull request Oct 4, 2017
Closed
@hugtalbot hugtalbot added the pr: status to review To notify reviewers to review this pull-request label Oct 5, 2017
@guparan guparan added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Oct 11, 2017
@hugtalbot hugtalbot added pr: status wip Development in the pull-request is still in progress and removed pr: status ready Approved a pull-request, ready to be squashed labels Oct 12, 2017
hugtalbot
hugtalbot approved these changes Oct 26, 2017
View reviewed changes
SofaKernel/modules/SofaRigid/RigidMapping.inl Outdated
@@ -268,7 +268,7 @@ void RigidMapping<TIn, TOut>::clear(int reserve)
template <class TIn, class TOut>
void RigidMapping<TIn, TOut>::setRepartition(unsigned int value)
{
serr<<"setRepartition: deprecated function"<<sendl;
serr<<helper::logging::Message::Deprecated<<"setRepartition function. Fill rigidIndexPerPoint instead."<<sendl;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it not use the "msg_deprecated" API ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(thank you Matthieu by the way for the PR!)

@hugtalbot hugtalbot added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status wip Development in the pull-request is still in progress labels Oct 26, 2017
@guparan guparan merged commit 4ce0d47 into sofa-framework:master Oct 26, 2017
@guparan guparan added this to the v17.12 milestone Dec 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugtalbot hugtalbot hugtalbot approved these changes

Assignees
No one assigned
Labels
pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v17.12
Development

Successfully merging this pull request may close these issues.

SofaRigid/RigidMapping.inl: possible bug
3 participants
@matthieu-nesme @hugtalbot @guparan