Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CMake] Fix SOFA install #4451

Merged
merged 2 commits into from
Jan 22, 2024
Merged

[CMake] Fix SOFA install #4451

merged 2 commits into from
Jan 22, 2024

Conversation

hugtalbot
Copy link
Contributor

@hugtalbot hugtalbot commented Jan 22, 2024 •
edited
Loading

Fix install further to #4410
+ minor warning fix

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@hugtalbot hugtalbot added pr: fix Fix a bug pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status to review To notify reviewers to review this pull-request labels Jan 22, 2024
@hugtalbot hugtalbot marked this pull request as ready for review January 22, 2024 20:28
@fredroy fredroy added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Jan 22, 2024
@fredroy fredroy merged commit f102d70 into sofa-framework:master Jan 22, 2024
22 checks passed
@bakpaul bakpaul added this to the v24.06 milestone May 21, 2024
@bakpaul bakpaul changed the title [CMake] Fix SOFA install [CMake] Fix SOFA install Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredroy fredroy fredroy approved these changes

Assignees
No one assigned
Labels
pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v24.06
Development

Successfully merging this pull request may close these issues.
3 participants
@hugtalbot @fredroy @bakpaul