Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Simulation.Common] Fix downstream project compilation with tinyXML2 #4506

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

bakpaul
Copy link
Contributor

@bakpaul bakpaul commented Feb 19, 2024

Remove tinyXML find package in the common config file because the linkage is private and thus it is not required to find it for links against Sofa.Simulation.Common.


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@bakpaul bakpaul added pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status to review To notify reviewers to review this pull-request pr: clean Cleaning the code pr: backport todo This PR will be backported into the release preceeding its milestone. labels Feb 19, 2024
@bakpaul bakpaul requested review from olivier-roussel and fredroy and removed request for olivier-roussel February 19, 2024 13:07
@bakpaul
Copy link
Contributor Author

bakpaul commented Feb 19, 2024

[ci-build][with-all-tests]

@bakpaul bakpaul merged commit af8f98a into sofa-framework:master Feb 19, 2024
22 checks passed
bakpaul added a commit that referenced this pull request Feb 19, 2024
…4506)

remove tinyXML find package in the common config file
@bakpaul bakpaul added this to the v23.12 milestone Feb 20, 2024
@bakpaul bakpaul added pr: backport done This PR has been backported into the release before its milestone. and removed pr: backport todo This PR will be backported into the release preceeding its milestone. labels Feb 20, 2024
@hugtalbot hugtalbot added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: backport done This PR has been backported into the release before its milestone. pr: clean Cleaning the code pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants