Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Simulation.Common] Fix tinyXML2 install for windows #4525

Merged
merged 2 commits into from
Feb 27, 2024
Merged

[Simulation.Common] Fix tinyXML2 install for windows #4525

merged 2 commits into from
Feb 27, 2024

Conversation

bakpaul
Copy link
Contributor

@bakpaul bakpaul commented Feb 23, 2024

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@bakpaul bakpaul added pr: fix Fix a bug pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status to review To notify reviewers to review this pull-request pr: backport todo This PR will be backported into the release preceeding its milestone. labels Feb 23, 2024
@bakpaul bakpaul added this to the v23.12 milestone Feb 23, 2024
fredroy
fredroy approved these changes Feb 26, 2024
View reviewed changes
Copy link
Contributor

@fredroy fredroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testède and approuvède 🫡

@hugtalbot hugtalbot merged commit 3300c00 into sofa-framework:master Feb 27, 2024
7 of 10 checks passed
bakpaul added a commit that referenced this pull request Feb 27, 2024
@bakpaul @hugtalbot
[Simulation.Common] Fix tinyXML2 install for windows (#4525)
8cdbb67 
Fix tinyXML install for windows

Co-authored-by: Hugo <hugo.talbot@sofa-framework.org>
@hugtalbot hugtalbot added pr: backport done This PR has been backported into the release before its milestone. and removed pr: backport todo This PR will be backported into the release preceeding its milestone. labels Feb 29, 2024
@hugtalbot hugtalbot added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugtalbot hugtalbot hugtalbot approved these changes

@fredroy fredroy fredroy approved these changes

@olivier-roussel olivier-roussel Awaiting requested review from olivier-roussel

@alxbilger alxbilger Awaiting requested review from alxbilger

Assignees
No one assigned
Labels
pr: backport done This PR has been backported into the release before its milestone. pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v23.12
Development

Successfully merging this pull request may close these issues.
3 participants
@bakpaul @fredroy @hugtalbot