-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Constraint.Lagrangian] Add fixed lagrangian constraint #4646
[Constraint.Lagrangian] Add fixed lagrangian constraint #4646
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good initiative. We will have 3 different ways to fix points. 👍
...agrangian/Model/src/sofa/component/constraint/lagrangian/model/FixedLagrangianConstraint.inl
Outdated
Show resolved
Hide resolved
...agrangian/Model/src/sofa/component/constraint/lagrangian/model/FixedLagrangianConstraint.inl
Outdated
Show resolved
Hide resolved
...agrangian/Model/src/sofa/component/constraint/lagrangian/model/FixedLagrangianConstraint.cpp
Outdated
Show resolved
Hide resolved
...agrangian/Model/src/sofa/component/constraint/lagrangian/model/FixedLagrangianConstraint.cpp
Outdated
Show resolved
Hide resolved
.../Lagrangian/Model/src/sofa/component/constraint/lagrangian/model/FixedLagrangianConstraint.h
Show resolved
Hide resolved
examples/Component/Constraint/Lagrangian/FixedLagrangianConstaint_Rigid3.scn
Outdated
Show resolved
Hide resolved
.../Lagrangian/Model/src/sofa/component/constraint/lagrangian/model/FixedLagrangianConstraint.h
Outdated
Show resolved
Hide resolved
.../Lagrangian/Model/src/sofa/component/constraint/lagrangian/model/FixedLagrangianConstraint.h
Show resolved
Hide resolved
...agrangian/Model/src/sofa/component/constraint/lagrangian/model/FixedLagrangianConstraint.inl
Show resolved
Hide resolved
...agrangian/Model/src/sofa/component/constraint/lagrangian/model/FixedLagrangianConstraint.inl
Outdated
Show resolved
Hide resolved
[ci-build][with-all-tests] |
[ci-build][with-all-tests] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I want to be peaky, I would say that you don't provide code for instantiation for other types than Vec3Types
and Rigid3Types
. For example, FixedProjectiveConstraint
also provides Vec2Types
, Vec1Types
, Vec6Types
and Rigid2Types
.
And if we look at Vec1Types
specifically, can you explain the difference between FixedLagrangianConstraint<Vec1Types>
and UniformLagrangianConstraint<Vec1Types>
?
The difference lies in the fact that the As for the other specialization, what I did was to replicate the two specialization already available for the |
a0b88e4
to
a134fc0
Compare
[ci-build][with-all-tests][force-full-build] |
…gid implementation
dc42be1
to
feb52c5
Compare
Add a lagrangian constraint working the same way as FixedProjectiveConstraint.
Added Vec3 and Rigid3 specialization.
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if